Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753423AbcD0PbL (ORCPT ); Wed, 27 Apr 2016 11:31:11 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:37698 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753250AbcD0PbG (ORCPT ); Wed, 27 Apr 2016 11:31:06 -0400 Date: Wed, 27 Apr 2016 16:30:57 +0100 From: Lee Jones To: Thierry Reding Cc: Laxman Dewangan , linus.walleij@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, gnurou@gmail.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, ijc+devicetree@hellion.org.uk, swarren@nvidia.com Subject: Re: [PATCH V10 1/6] mfd: add device-tree binding doc for PMIC max77620/max20024 Message-ID: <20160427153057.GF4892@dell> References: <1459348188-11726-1-git-send-email-ldewangan@nvidia.com> <1459348188-11726-2-git-send-email-ldewangan@nvidia.com> <20160427124959.GC4892@dell> <20160427150443.GC4176@ulmo.ba.sec> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160427150443.GC4176@ulmo.ba.sec> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2255 Lines: 74 On Wed, 27 Apr 2016, Thierry Reding wrote: > On Wed, Apr 27, 2016 at 01:49:59PM +0100, Lee Jones wrote: > > On Wed, 30 Mar 2016, Laxman Dewangan wrote: > > > > > The MAXIM PMIC MAX77620 and MAX20024 are power management IC > > > which supports RTC, GPIO, DCDC/LDO regulators, interrupt, > > > watchdog etc. > > > > > > Add DT binding document for the different functionality of > > > this device. > > > > > > Signed-off-by: Laxman Dewangan > > > Acked-by: Rob Herring > > > > > > --- > > > Changes from V1: > > > - Added units in some of properties. > > > - Change the boolean property to tristate type and detail some of > > > properties. > > > > > > Change from V2: > > > - added unit in period related dt property. > > > > > > Change from V3: None > > > - Added Rob's ack. > > > > > > Changes from V4: > > > - A- Provide more details in the dt binding doc. > > > - Take care of fps nodes. > > > - Split the submodule's DT binding doc on respective folder. > > > - Drop the battery charger and low battery binding and related code as > > > it need to go on power driver. > > > > > > Change from V5: > > > - None > > > > > > Change from V6: > > > -start the patch title with mfd instead of DT: mfd: > > > > > > Change from V7: > > > - Better describe the FPS to make more clear. > > > > > > Changes from V8: > > > None > > > > > > Changes from V9: > > > None > > > > > > Documentation/devicetree/bindings/mfd/max77620.txt | 143 +++++++++++++++++++++ > > > include/dt-bindings/mfd/max77620.h | 39 ++++++ > > > 2 files changed, 182 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/mfd/max77620.txt > > > create mode 100644 include/dt-bindings/mfd/max77620.h > > > > For my own reference: > > > > Acked-by: Lee Jones > > Hi Lee, > > I'm confused now. Were you going to pick this up, or are you waiting for > someone else to do it? I will pick it up once I'm good with the driver. The "For my own reference" tags are just to let me know not to waste my time and re-review. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog