Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752914AbcD0Pqv (ORCPT ); Wed, 27 Apr 2016 11:46:51 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:34824 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753760AbcD0Pqr (ORCPT ); Wed, 27 Apr 2016 11:46:47 -0400 Reply-To: nicolas.dichtel@6wind.com Subject: Re: [PATCH net-next 9/9] taskstats: use the libnl API to align nlattr on 64-bit References: <1461339084-3849-1-git-send-email-nicolas.dichtel@6wind.com> <1461339084-3849-10-git-send-email-nicolas.dichtel@6wind.com> <57201287.80002@gmail.com> <57206A47.2010906@6wind.com> <5720B0A2.1030405@gmail.com> To: Balbir Singh , netdev@vger.kernel.org Cc: davem@davemloft.net, linux-kernel@vger.kernel.org, linux-wpan@vger.kernel.org, aar@pengutronix.de, pablo@netfilter.org, kaber@trash.net, kadlec@blackhole.kfki.hu, pshelar@nicira.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, netfilter-devel@vger.kernel.org, dev@openvswitch.org, steffen.klassert@secunet.com, herbert@gondor.apana.org.au From: Nicolas Dichtel Organization: 6WIND Message-ID: <5720DED8.4090706@6wind.com> Date: Wed, 27 Apr 2016 17:46:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <5720B0A2.1030405@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 372 Lines: 15 Le 27/04/2016 14:29, Balbir Singh a ?crit : [snip] > Please try > > https://www.kernel.org/doc/Documentation/accounting/getdelays.c A patch follows this mail to fix that. > > iotop uses it as well. My concern is ABI breakage of user space. My test is ok here, I didn't see a problem. Code review (from here http://repo.or.cz/w/iotop.git) is also ok. Regards, Nicolas