Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753466AbcD0PuL (ORCPT ); Wed, 27 Apr 2016 11:50:11 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:36117 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752270AbcD0PuI (ORCPT ); Wed, 27 Apr 2016 11:50:08 -0400 Reply-To: nicolas.dichtel@6wind.com Subject: Re: [PATCH net-next] taskstats: fix nl parsing in accounting/getdelays.c References: <5720DED8.4090706@6wind.com> <1461772077-3216-1-git-send-email-nicolas.dichtel@6wind.com> To: bsingharora@gmail.com Cc: netdev@vger.kernel.org, davem@davemloft.net, linux-kernel@vger.kernel.org, linux-wpan@vger.kernel.org, aar@pengutronix.de, pablo@netfilter.org, kaber@trash.net, kadlec@blackhole.kfki.hu, pshelar@nicira.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, netfilter-devel@vger.kernel.org, dev@openvswitch.org, steffen.klassert@secunet.com, herbert@gondor.apana.org.au From: Nicolas Dichtel Organization: 6WIND Message-ID: <5720DFA1.3080503@6wind.com> Date: Wed, 27 Apr 2016 17:49:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1461772077-3216-1-git-send-email-nicolas.dichtel@6wind.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 644 Lines: 12 Le 27/04/2016 17:47, Nicolas Dichtel a écrit : > The type TASKSTATS_TYPE_NULL should always be ignored. > > When jumping to the next attribute, only the length of the current > attribute should be added, not the length of all nested attributes. > This last bug was not visible before commit 80df554275c2, because the > kernel didn't put more than two nested attributes. > > Fixes: a3baf649ca9c ("[PATCH] per-task-delay-accounting: documentation") > Fixes: 80df554275c2 ("taskstats: use the libnl API to align nlattr on 64-bit") > Signed-off-by: Nicolas Dichtel Please, drop this version. I fatfingered my rebase.