Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753432AbcD0Q5c (ORCPT ); Wed, 27 Apr 2016 12:57:32 -0400 Received: from mail-pf0-f175.google.com ([209.85.192.175]:34870 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753345AbcD0Q5X (ORCPT ); Wed, 27 Apr 2016 12:57:23 -0400 Date: Wed, 27 Apr 2016 10:57:12 -0600 From: Brian Norris To: Arnd Bergmann Cc: David Woodhouse , Linus Walleij , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] physmap_of: ensure versatile code is reachable Message-ID: <20160427165712.GA7266@localhost> References: <1461625501-2160538-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461625501-2160538-1-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 614 Lines: 16 On Tue, Apr 26, 2016 at 01:04:38AM +0200, Arnd Bergmann wrote: > With the newly added physmap_of_versatile code, we get a build error > when physmap_of is in a module, because of_flash_probe_versatile > is not exported: > > ERROR: "of_flash_probe_versatile" [drivers/mtd/maps/physmap_of.ko] undefined! > > This adds the export, and changes the Makefile so that the code is > also put into a loadable module rather than built-in when physmap_of > itself is a module. > > Signed-off-by: Arnd Bergmann Acked-by: Brian Norris I presume you're taking this in arm-soc.