Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753830AbcD0SIP (ORCPT ); Wed, 27 Apr 2016 14:08:15 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:46293 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752575AbcD0SIM (ORCPT ); Wed, 27 Apr 2016 14:08:12 -0400 Message-ID: <1461780469.5102.0.camel@decadent.org.uk> Subject: Re: [PATCH 3.2 085/115] veth: =?UTF-8?Q?don=E2=80=99t?= modify ip_summed; doing so treats packets with bad checksums as good. From: Ben Hutchings To: Ben Greear , linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: akpm@linux-foundation.org, "David S. Miller" , Vijay Pandurangan , Cong Wang , netdev@vger.kernel.org, Evan Jones , Nicolas Dichtel , Phil Sutter , Toshiaki Makita Date: Wed, 27 Apr 2016 20:07:49 +0200 In-Reply-To: <5720E1F0.9010203@candelatech.com> References: <5720E1F0.9010203@candelatech.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-yJJVXtP3DtRwt84qu0z5" X-Mailer: Evolution 3.18.5.1-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 92.40.248.155 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1750 Lines: 50 --=-yJJVXtP3DtRwt84qu0z5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2016-04-27 at 08:59 -0700, Ben Greear wrote: > On 04/26/2016 04:02 PM, Ben Hutchings wrote: > >=20 > > 3.2.80-rc1 review patch.=C2=A0=C2=A0If anyone has any objections, pleas= e let me know. > I would be careful about this.=C2=A0=C2=A0It causes regressions when send= ing > PACKET_SOCKET buffers from user-space to veth devices. >=20 > There was a proposed upstream fix for the regression, but it has not gone > into the tree as far as I know. >=20 > http://www.spinics.net/lists/netdev/msg370436.html [...] OK, I'll drop this for now. Ben. --=20 Ben Hutchings Once a job is fouled up, anything done to improve it makes it worse. --=-yJJVXtP3DtRwt84qu0z5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCgAGBQJXIP/1AAoJEOe/yOyVhhEJUDsQAJ15FuYzbF9Po4XuBxMDT2QJ BebRpA0KpCrtiV+ByAUYUYD0FnFz0pWAnG5RzpD2MasmUns8kN1Pk/F8tinzAeUz P/t75bTh62Gh12UfmBc6AJgy+7e3Q4i6ymOf1cS7yBrg/Wq8QwUlOifdZdehIqQy cLBqbIoIR8N7Vp1e4cB3DcoGb4RYQc49QP50SqfBIU++ugS9dxX5aQw165nigb1G Z+5cGsUGYDuXT9lSsCMlg758IAxd4TJYx1/2n9VfD9xF/bRuORHWvPref3sX3hqX JSYpnOAptIpF5mw5H50NAaDIuZQ/LA8blL6mN1jlLaoiwXE8eyZoN1BSvkAUkmyk vjGIw0/gSMEZv/sjCZJZ6mU7+37pk4LvNQNRdpiod3Jy3iGv+otKogCOomK4G8GN po7Xx5hDj1crkAxbf5YTxHc/0YO2RsFY4OEetntXLTL1/ZemIrDaawQdOF13IkOf pKwKzbwyBeEj/vgkzcFjjT3P0y4VpCAI0uEeoEMa9VrECttiRNY/z7jDRCmhscJx 0UCJfyl7pvm6P/IBxfcxXbrGzVlRyVp5Fr+b8GOXRRHibEkAttVccBfOP45LfE8a rEnE75U5H9HglG9A3rZplDRX0DmDQuqlKxBydia9Ncl1O+5HOOYLwRyCJbu2GkdJ QgGKvhqb/tp3AdcM7DA2 =L7lx -----END PGP SIGNATURE----- --=-yJJVXtP3DtRwt84qu0z5--