Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753769AbcD0Sjx (ORCPT <rfc822;w@1wt.eu>);
	Wed, 27 Apr 2016 14:39:53 -0400
Received: from hqemgate14.nvidia.com ([216.228.121.143]:9040 "EHLO
	hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753738AbcD0Sju (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 27 Apr 2016 14:39:50 -0400
X-PGP-Universal: processed;
	by hqnvupgp07.nvidia.com on Wed, 27 Apr 2016 11:39:15 -0700
Message-ID: <572104AA.7080500@nvidia.com>
Date: Wed, 27 Apr 2016 23:57:54 +0530
From: Laxman Dewangan <ldewangan@nvidia.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
MIME-Version: 1.0
To: Lee Jones <lee.jones@linaro.org>
CC: <linus.walleij@linaro.org>, <robh+dt@kernel.org>, <mark.rutland@arm.com>,
        <gnurou@gmail.com>, <linux-kernel@vger.kernel.org>,
        <linux-gpio@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <ijc+devicetree@hellion.org.uk>, <swarren@nvidia.com>,
        <treding@nvidia.com>, Mallikarjun Kasoju <mkasoju@nvidia.com>
Subject: Re: [PATCH V10 2/6] mfd: max77620: add core driver for MAX77620/MAX20024
References: <1459348188-11726-1-git-send-email-ldewangan@nvidia.com> <1459348188-11726-3-git-send-email-ldewangan@nvidia.com> <20160427151947.GD4892@dell>
In-Reply-To: <20160427151947.GD4892@dell>
X-Originating-IP: [10.19.65.30]
X-ClientProxiedBy: DRHKMAIL102.nvidia.com (10.25.59.16) To
 bgmail102.nvidia.com (10.25.59.11)
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1781
Lines: 59


On Wednesday 27 April 2016 08:49 PM, Lee Jones wrote:
> On Wed, 30 Mar 2016, Laxman Dewangan wrote:
>
>> +#define MAX77620_MFD_CELL_RES(_name, _res)			\
>> +	{							\
>> +		.name = (_name),				\
>> +		.resources = (_res),				\
>> +		.num_resources = ARRAY_SIZE((_res)),		\
>> +	}
> I'm *still* not accepting this.
>
>> +
>> +static struct mfd_cell max20024_children[] = {
>> +	MAX77620_MFD_CELL_NAME("max20024-pinctrl"),
>> +	MAX77620_MFD_CELL_RES("max20024-gpio", gpio_resources),
>> +	MAX77620_MFD_CELL_NAME("max20024-pmic"),
>> +	MAX77620_MFD_CELL_RES("max77620-rtc", rtc_resources),
>> +	MAX77620_MFD_CELL_RES("max20024-power", power_resources),
>> +	MAX77620_MFD_CELL_NAME("max20024-watchdog"),
>> +	MAX77620_MFD_CELL_NAME("max20024-clock"),
>> +};
> If you want this submission to be accepted this cycle, you're going to
> have to convert this to the traditional way of defining MFD children.

Yaah, I want to have this in current cycle.
Will it be fine as follows? (To have quick agreement)

static const struct mfd_cell max77620_children[] = {
         {
                 .name = "max77620-pinctrl",
         }, {
                 .name = "max77620-gpio",
                 .resource = gpio_resources,
                 .num_resources = ARRAY_SIZE(gpio_resources),
         }, {
         /* and so on */
         },
};


>
>> +		if (x >= tperiod)
>> +			return i;
>> +	}
>> +
>> +	return i;
>> +}
>> +
>> +static int max77620_config_fps(struct max77620_chip *chip,
>> +			       struct device_node *fps_np)
> Lots of mention of 'FPS' here, but noting to so what that is?
>
> What does FPS stand for and what does the FPS do?

FPS is Flexible Power Sequence. It is explained in DT binding doc.

However, I will document the function to make it more clear in next 
revision.