Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753095AbcD0TXo (ORCPT ); Wed, 27 Apr 2016 15:23:44 -0400 Received: from mout.gmx.net ([212.227.15.15]:62783 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751774AbcD0TXm (ORCPT ); Wed, 27 Apr 2016 15:23:42 -0400 Subject: Re: [PATCH] parisc: fix a bug when syscall number of tracee is __NR_Linux_syscalls To: "Dmitry V. Levin" , "James E.J. Bottomley" References: <20160427015611.GA23316@altlinux.org> Cc: Mike Frysinger , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org From: Helge Deller Message-ID: <572111A0.706@gmx.de> Date: Wed, 27 Apr 2016 21:23:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20160427015611.GA23316@altlinux.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Qamy7Er8svPP5eHXr0IV2EI/YQbVzF9jli2N2pJzjuTJZq7Z/u9 wMpDFldHwv3yZCk8cpyuvjChfRBs0L81wCHVPhTttB4KlBtrgTzC+qYBrG1tipT1Up4s+nt +6GcIITWtnHEmncYcvFOT2TZUqw1VF4k3tZA6yCHEgG3Fz9jpf+5lyaxeCYftvgeY7tqfWf 0/w3rCRGy32B1F5XV0Ssw== X-UI-Out-Filterresults: notjunk:1;V01:K0:PRtLlJk6NeI=:M2B2CjlFtxPlBsoKeDKJL2 h+itvOIllBMmu0sRKlNtFunFc6Cup1uP8Nj1c3yS3IXn7mpLZBX1Rf8BFG2gdARGffONS38hY RaMFQt/aaDQnBRedoVMd9mSQaL7ZNN0ANNNInTcDbsSBwUQ4b+9IiYbTwlHunPRn5z6xevlMd DdztR1m2sRI3Uo/18CmDapj4gpSbcZHs8Z69oHZAzNdStZ5oHWGxuU00uFXEjfcP8cUzzImBl eJaIJGje3n+RsfvhyNvO8t0tRHh/ilTBQpKAAWeG8dPGWzYj5Lf4Jzi/Kt0ln28RgS+jUrOf2 CRfbfEhPLdC3VpFGXo2K6ELViD0rn3Q2BP0ozSZr9DOMz33YCa+5ufifEHSgm987TkJokFW6K P/MnWXZXRBmQQt7KS8A1cJpWLK+Uk14xiCVmxW/lQ2OEFDuVBk3RrSxkwiiTbNqv6rW9BUomQ DQKeu04MbRBVbbK+jU3S2sjr/rowWJCzD1yUYWu+dOLXUQDx8997yMCNYDMKN9mFlWfI7TCVj CLKqm/R9VaVq+menUzX0co/iWSoVEEDKN5Hji09LSZbQ59622vYIodKMk+Z2Rd+cz1DAWElzi X8eZMF3WaoJD/sq7vbbY8yCUbaOuopQxWb0PGJivw9PrPT89DAVNgJxA+UPJXVnFtx5VVQ0J1 FWR/uXFx2OoZIt6omRExaItsRQs/UZMA0ZaITi5XY3n5Aw0OYRVPJSxa/IKFD4bC5llCEdP6K 8VPNvTMGXcHunsEuBNPa7H/iKGP2zV1kaRv1jQGGl5hl9QYqc2OVpbaWL5EW0C+531NRPHAx0 nM4IcSX Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1061 Lines: 35 On 27.04.2016 03:56, Dmitry V. Levin wrote: > Do not load one entry beyond the end of the syscall table when the > syscall number of a traced process equals to __NR_Linux_syscalls. > Similar bug with regular processes was fixed by commit 3bb457af4fa8 > ("[PARISC] Fix bug when syscall nr is __NR_Linux_syscalls"). > > This bug was found by strace test suite. > > Cc: stable@vger.kernel.org > Signed-off-by: Dmitry V. Levin Acked-by: Helge Deller Thanks! Helge > --- > arch/parisc/kernel/syscall.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/parisc/kernel/syscall.S b/arch/parisc/kernel/syscall.S > index c976ebf..57b4836 100644 > --- a/arch/parisc/kernel/syscall.S > +++ b/arch/parisc/kernel/syscall.S > @@ -344,7 +344,7 @@ tracesys_next: > #endif > > cmpib,COND(=),n -1,%r20,tracesys_exit /* seccomp may have returned -1 */ > - comiclr,>>= __NR_Linux_syscalls, %r20, %r0 > + comiclr,>> __NR_Linux_syscalls, %r20, %r0 > b,n .Ltracesys_nosys > > LDREGX %r20(%r19), %r19 >