Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753679AbcD0URS (ORCPT <rfc822;w@1wt.eu>);
	Wed, 27 Apr 2016 16:17:18 -0400
Received: from mail-lf0-f67.google.com ([209.85.215.67]:33862 "EHLO
	mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753256AbcD0URP (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 27 Apr 2016 16:17:15 -0400
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH 3/3] lightnvm: rename dma helper functions
From: =?utf-8?Q?Javier_Gonz=C3=A1lez?= <javigon.napster@gmail.com>
X-Mailer: iPhone Mail (13E233)
In-Reply-To: <57210AEA.8010206@bjorling.me>
Date: Wed, 27 Apr 2016 22:17:11 +0200
Cc: =?utf-8?Q?Javier_Gonz=C3=A1lez?= <jg@lightnvm.io>, mb@lightnvm.io,
        linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
        =?utf-8?Q?Javier_Gonz=C3=A1lez?= <javier@cnexlabs.com>
Content-Transfer-Encoding: 7bit
Message-Id: <974FE028-A0AD-44D8-9CF9-D690EC08C0CF@gmail.com>
References: <1461778138-23116-1-git-send-email-javier@javigon.com> <1461778138-23116-3-git-send-email-javier@javigon.com> <57210AEA.8010206@bjorling.me>
To: =?utf-8?Q?Matias_Bj=C3=B8rling?= <m@bjorling.me>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 540
Lines: 19


>>      if (dev->ops->max_phys_sect > 1) {
>> -        dev->ppalist_pool = dev->ops->create_dma_pool(dev, "ppalist");
>> -        if (!dev->ppalist_pool) {
>> +        dev->dma_page_pool = dev->ops->create_dma_pool(dev, "ppalist");
> 
> rename to dmapool or something similar?
> 
>> +        if (!dev->dma_page_pool) {
>>              pr_err("nvm: could not create ppa pool\n");
> 
> Make sure to fix up the text here as well. Else it looks good.
> 
>>              ret = -ENOMEM;
> 

Thanks. I'll fix it and resubmit tomorrow. 

Javier.