Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753375AbcD0VJw (ORCPT ); Wed, 27 Apr 2016 17:09:52 -0400 Received: from lists.s-osg.org ([54.187.51.154]:43061 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752236AbcD0VJv (ORCPT ); Wed, 27 Apr 2016 17:09:51 -0400 Subject: Re: [PATCH v2 1/3] ARM: dts: exynos: Define vqmmc for SD card and allow disabling regulators on Odroid X/X2/U3 To: Krzysztof Kozlowski , Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Tobias Jakobi , Marek Szyprowski References: <1461765620-6833-1-git-send-email-k.kozlowski@samsung.com> Cc: linux-mmc@vger.kernel.org, linux.amoon@gmail.com, Bartlomiej Zolnierkiewicz From: Javier Martinez Canillas Message-ID: Date: Wed, 27 Apr 2016 17:09:38 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <1461765620-6833-1-git-send-email-k.kozlowski@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 583 Lines: 21 Hello Krzysztof, On 04/27/2016 10:00 AM, Krzysztof Kozlowski wrote: > The SD-card vmmc-supply contained incorrectly two regulators. The second > one is ignored. Fix this by defining proper vmmc and vqmmc supplies. > Additionally these regulators do not have to be always on, so allow > disabling them to reduce energy consumption. > > Signed-off-by: Krzysztof Kozlowski > > --- Patch looks good to me. Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America