Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753413AbcD0VMi (ORCPT ); Wed, 27 Apr 2016 17:12:38 -0400 Received: from mail.kernel.org ([198.145.29.136]:53358 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752654AbcD0VMh (ORCPT ); Wed, 27 Apr 2016 17:12:37 -0400 Date: Wed, 27 Apr 2016 18:12:32 -0300 From: Arnaldo Carvalho de Melo To: Masami Hiramatsu Cc: linux-kernel@vger.kernel.org, Namhyung Kim , Peter Zijlstra , Ingo Molnar , Hemant Kumar , Ananth N Mavinakayanahalli Subject: Re: [PATCH perf/core v5 02/15] perf-buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid Message-ID: <20160427211232.GQ11033@kernel.org> References: <20160427183701.23446.15293.stgit@devbox> <20160427183723.23446.47139.stgit@devbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160427183723.23446.47139.stgit@devbox> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 801 Lines: 23 Em Thu, Apr 28, 2016 at 03:37:23AM +0900, Masami Hiramatsu escreveu: > From: Masami Hiramatsu > > Use path/to/bin/buildid/elf instead of path/to/bin/buildid > to store corresponding elf binary. > This also stores vdso in buildid/vdso, kallsyms in buildid/kallsyms. > > Note that the existing caches are not updated until user adds > or updates the cache. Anyway, if there is the old style build-id > cache it falls back to use it. (IOW, it is backward compatible) I reworded this to: "If there is old style build-id cache content, i.e. links to path/to/bin/buildid/aa/bbccdd, it will still be accessible, IOW, this is backard compatible." This part "existing caches are not updated until the user updates de cache" sounds confusing. Anyway, applied. - Arnaldo