Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752544AbcD0Xcr (ORCPT ); Wed, 27 Apr 2016 19:32:47 -0400 Received: from jbeekman.nl ([149.210.172.151]:49149 "EHLO daxilon.jbeekman.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751019AbcD0Xcq (ORCPT ); Wed, 27 Apr 2016 19:32:46 -0400 To: Jarkko Sakkinen References: <1461605698-12385-1-git-send-email-jarkko.sakkinen@linux.intel.com> <1461605698-12385-4-git-send-email-jarkko.sakkinen@linux.intel.com> <57206102.3050507@jbeekman.nl> <20160427124056.GA22003@intel.com> Cc: gregkh@linuxfoundation.org, "open list:STAGING SUBSYSTEM" , "maintainer:X86 ARCHITECTURE 32-BIT AND 64-BIT" , "open list:X86 ARCHITECTURE 32-BIT AND 64-BIT" , Ingo Molnar , "H. Peter Anvin" , Thomas Gleixner From: Jethro Beekman X-Enigmail-Draft-Status: N1110 Message-ID: <57214C07.8090806@jbeekman.nl> Date: Wed, 27 Apr 2016 16:32:23 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160427124056.GA22003@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 169.229.59.5 X-SA-Exim-Mail-From: kernel@jbeekman.nl X-Spam-Report: Content analysis details: (-1.0 points, 5.0 required) pts rule name description --- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP Subject: Re: [PATCH 3/6] intel_sgx: driver for Intel Secure Guard eXtensions Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 861 Lines: 22 On 27-04-16 05:40, Jarkko Sakkinen wrote: >> The hardware supports calling EEXTEND on only a part of a page, I think the >> driver should also support that. > > Why would you want to do that? You might have segments in a binary that don't start at the beginning of a page or that end before the end of a page. For example: Type Offset VirtAddr PhysAddr FileSiz MemSiz Flags Align LOAD 0x0000000000000000 0x0000000000000000 0x0000000000000000 0x000000000001bcac 0x000000000001bcac R E 1000 LOAD 0x000000000001c8e8 0x000000000001c8e8 0x000000000001c8e8 0x0000000000000790 0x0000000000000c68 RW 1000 There's no need to measure the extra padding (0x1bd00--0x1c7ff and 0x1cb00--0x1cfff) in this case. > /Jarkko Jethro