Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752995AbcD0Xyh (ORCPT ); Wed, 27 Apr 2016 19:54:37 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:24994 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751829AbcD0Xyg (ORCPT ); Wed, 27 Apr 2016 19:54:36 -0400 To: Paul Gortmaker Cc: , Christoph Hellwig , Ming Lin , Sagi Grimberg , "Martin K . Petersen" Subject: Re: [PATCH v2] lib: make sg_pool tristate instead of bool From: "Martin K. Petersen" Organization: Oracle Corporation References: <1461465895-676-1-git-send-email-paul.gortmaker@windriver.com> Date: Wed, 27 Apr 2016 19:54:19 -0400 In-Reply-To: <1461465895-676-1-git-send-email-paul.gortmaker@windriver.com> (Paul Gortmaker's message of "Sat, 23 Apr 2016 22:44:55 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 766 Lines: 21 >>>>> "Paul" == Paul Gortmaker writes: Paul> The recently added Kconfig controlling compilation of this code Paul> is: lib/Kconfig:config SG_POOL lib/Kconfig: def_bool n Paul> ...meaning that it currently is not being built as a module by Paul> anyone, and that tripped my audit looking for modular code that is Paul> essentially orphaned (i.e. module_exit, and .remove fcns in Paul> non-modular drivers.) Paul> In the following discussion, Ming Lin indicated that the original Paul> intention was to have it tristate, so here we convert it Paul> accordingly. Paul> Also fix up a couple spelling issues that appear in the Paul> surrounding patch context. Somebody please review... -- Martin K. Petersen Oracle Linux Engineering