Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752676AbcD1AOv (ORCPT ); Wed, 27 Apr 2016 20:14:51 -0400 Received: from mail2.candelatech.com ([208.74.158.173]:37832 "EHLO mail2.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752195AbcD1AOs (ORCPT ); Wed, 27 Apr 2016 20:14:48 -0400 Subject: =?UTF-8?Q?Re:_[PATCH_3.2_085/115]_veth:_don=e2=80=99t_modify_ip=5fs?= =?UTF-8?Q?ummed;_doing_so_treats_packets_with_bad_checksums_as_good.?= To: Hannes Frederic Sowa , Ben Hutchings , linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <5720E1F0.9010203@candelatech.com> <1461780469.5102.0.camel@decadent.org.uk> <1461801603.3971874.591751457.2DB91B98@webmail.messagingengine.com> Cc: akpm@linux-foundation.org, "David S. Miller" , Vijay Pandurangan , Cong Wang , netdev@vger.kernel.org, Evan Jones , Nicolas Dichtel , Phil Sutter , Toshiaki Makita , xiyou.wangcong@gmail.com From: Ben Greear Organization: Candela Technologies Message-ID: <572155F4.10405@candelatech.com> Date: Wed, 27 Apr 2016 17:14:44 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1461801603.3971874.591751457.2DB91B98@webmail.messagingengine.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2302 Lines: 72 On 04/27/2016 05:00 PM, Hannes Frederic Sowa wrote: > Hi Ben, > > On Wed, Apr 27, 2016, at 20:07, Ben Hutchings wrote: >> On Wed, 2016-04-27 at 08:59 -0700, Ben Greear wrote: >>> On 04/26/2016 04:02 PM, Ben Hutchings wrote: >>>> >>>> 3.2.80-rc1 review patch. If anyone has any objections, please let me know. >>> I would be careful about this. It causes regressions when sending >>> PACKET_SOCKET buffers from user-space to veth devices. >>> >>> There was a proposed upstream fix for the regression, but it has not gone >>> into the tree as far as I know. >>> >>> http://www.spinics.net/lists/netdev/msg370436.html >> [...] >> >> OK, I'll drop this for now. > > The fall out from not having this patch is in my opinion a bigger > fallout than not having this patch. This patch fixes silent data > corruption vs. the problem Ben Greear is talking about, which might not > be that a common usage. > > What do others think? > > Bye, > Hannes > This patch from Cong Wang seems to fix the regression for me, I think it should be added and tested in the main tree, and then apply them to stable as a pair. http://dmz2.candelatech.com/?p=linux-4.4.dev.y/.git;a=commitdiff;h=8153e983c0e5eba1aafe1fc296248ed2a553f1ac;hp=454b07405d694dad52e7f41af5816eed0190da8a diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index da1ae0e..f8cc758 100644 (file) --- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c @@ -1926,6 +1926,7 @@ retry: goto out_unlock; } + skb->ip_summed = CHECKSUM_UNNECESSARY; skb->protocol = proto; skb->dev = dev; skb->priority = sk->sk_priority; @@ -2352,6 +2353,7 @@ static int tpacket_fill_skb(struct packet_sock *po, struct sk_buff *skb, ph.raw = frame; + skb->ip_summed = CHECKSUM_UNNECESSARY; skb->protocol = proto; skb->dev = dev; skb->priority = po->sk.sk_priority; @@ -2776,6 +2778,7 @@ static int packet_snd(struct socket *sock, struct msghdr *msg, size_t len) goto out_free; } + skb->ip_summed = CHECKSUM_UNNECESSARY; skb->protocol = proto; skb->dev = dev; skb->priority = sk->sk_priority; Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com