Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752414AbcD1BSi (ORCPT ); Wed, 27 Apr 2016 21:18:38 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:20655 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751267AbcD1BSg (ORCPT ); Wed, 27 Apr 2016 21:18:36 -0400 To: Alexey Khoroshilov Cc: Sreekanth Reddy , Sathya Prakash , Chaitra P B , Suganath Prabu Subramani , MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: Re: [PATCH] mptsas: fix checks for dma mapping errors From: "Martin K. Petersen" Organization: Oracle Corporation References: <1460761950-8006-1-git-send-email-khoroshilov@ispras.ru> Date: Wed, 27 Apr 2016 21:18:17 -0400 In-Reply-To: <1460761950-8006-1-git-send-email-khoroshilov@ispras.ru> (Alexey Khoroshilov's message of "Sat, 16 Apr 2016 02:12:29 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 314 Lines: 10 >>>>> "Alexey" == Alexey Khoroshilov writes: Alexey> mptsas_smp_handler() checks for dma mapping errors by comparison Alexey> returned address with zero, while pci_dma_mapping_error() should Alexey> be used. Broadcom folks, please review! -- Martin K. Petersen Oracle Linux Engineering