Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752593AbcD1Bv4 (ORCPT ); Wed, 27 Apr 2016 21:51:56 -0400 Received: from mail.kernel.org ([198.145.29.136]:40222 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750785AbcD1Bvz (ORCPT ); Wed, 27 Apr 2016 21:51:55 -0400 Date: Thu, 28 Apr 2016 10:51:50 +0900 From: Masami Hiramatsu To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Namhyung Kim , Peter Zijlstra , Ingo Molnar , Hemant Kumar , Ananth N Mavinakayanahalli Subject: Re: [PATCH perf/core v5 02/15] perf-buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid Message-Id: <20160428105150.d13b50f0ed3cae33b587c865@kernel.org> In-Reply-To: <20160427212350.GR11033@kernel.org> References: <20160427183701.23446.15293.stgit@devbox> <20160427183723.23446.47139.stgit@devbox> <20160427212350.GR11033@kernel.org> X-Mailer: Sylpheed 3.4.3 (GTK+ 2.24.28; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1270 Lines: 36 On Wed, 27 Apr 2016 18:23:50 -0300 Arnaldo Carvalho de Melo wrote: > Em Thu, Apr 28, 2016 at 03:37:23AM +0900, Masami Hiramatsu escreveu: > > From: Masami Hiramatsu > > > > Use path/to/bin/buildid/elf instead of path/to/bin/buildid > > to store corresponding elf binary. > > This also stores vdso in buildid/vdso, kallsyms in buildid/kallsyms. > > > > Note that the existing caches are not updated until user adds > > or updates the cache. Anyway, if there is the old style build-id > > cache it falls back to use it. (IOW, it is backward compatible) > > > > Signed-off-by: Masami Hiramatsu > > Signed-off-by: Masami Hiramatsu > > --- > > Changes in v5: > > - Support old style buildid caches. > > > + /* Remove old style build-id cache */ > > + if (__is_regular_file(dir_name)) > > + if (unlink(dir_name)) > > + goto out_free; > > Shouldn't this just fail and require the user to use --force/-f or purge > first? No, I don't think so, because the old style build-id is useless for probe-cache in anyway, and after applying this patch, perf can use new one seemlessly. So let just renew it :) Thank you, -- Masami Hiramatsu