Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753301AbcD1Bw4 (ORCPT ); Wed, 27 Apr 2016 21:52:56 -0400 Received: from mail.kernel.org ([198.145.29.136]:40291 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753194AbcD1Bwz (ORCPT ); Wed, 27 Apr 2016 21:52:55 -0400 Date: Thu, 28 Apr 2016 10:52:50 +0900 From: Masami Hiramatsu To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Namhyung Kim , Peter Zijlstra , Ingo Molnar , Hemant Kumar , Ananth N Mavinakayanahalli Subject: Re: [PATCH perf/core v5 02/15] perf-buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid Message-Id: <20160428105250.342ad701ff83a12e6ab7bcb8@kernel.org> In-Reply-To: <20160427211232.GQ11033@kernel.org> References: <20160427183701.23446.15293.stgit@devbox> <20160427183723.23446.47139.stgit@devbox> <20160427211232.GQ11033@kernel.org> X-Mailer: Sylpheed 3.4.3 (GTK+ 2.24.28; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1002 Lines: 33 On Wed, 27 Apr 2016 18:12:32 -0300 Arnaldo Carvalho de Melo wrote: > Em Thu, Apr 28, 2016 at 03:37:23AM +0900, Masami Hiramatsu escreveu: > > From: Masami Hiramatsu > > > > Use path/to/bin/buildid/elf instead of path/to/bin/buildid > > to store corresponding elf binary. > > This also stores vdso in buildid/vdso, kallsyms in buildid/kallsyms. > > > > Note that the existing caches are not updated until user adds > > or updates the cache. Anyway, if there is the old style build-id > > cache it falls back to use it. (IOW, it is backward compatible) > > I reworded this to: > > "If there is old style build-id cache content, i.e. links to > path/to/bin/buildid/aa/bbccdd, it will still be accessible, IOW, this is > backard compatible." > > This part "existing caches are not updated until the user updates de > cache" sounds confusing. Ah, I see. Thank you! > > Anyway, applied. > > - Arnaldo -- Masami Hiramatsu