Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753003AbcD1CsF (ORCPT ); Wed, 27 Apr 2016 22:48:05 -0400 Received: from LGEAMRELO13.lge.com ([156.147.23.53]:38348 "EHLO lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752630AbcD1CsD (ORCPT ); Wed, 27 Apr 2016 22:48:03 -0400 X-Original-SENDERIP: 156.147.1.125 X-Original-MAILFROM: namhyung@kernel.org X-Original-SENDERIP: 165.244.98.150 X-Original-MAILFROM: namhyung@kernel.org X-Original-SENDERIP: 10.177.227.17 X-Original-MAILFROM: namhyung@kernel.org Date: Thu, 28 Apr 2016 11:47:53 +0900 From: Namhyung Kim To: Masami Hiramatsu CC: Arnaldo Carvalho de Melo , , Peter Zijlstra , Ingo Molnar , Hemant Kumar , Ananth N Mavinakayanahalli Subject: Re: [PATCH perf/core v5 05/15] perf probe: Use cache entry if possible Message-ID: <20160428024753.GB15597@sejong.aot.lge.com> References: <20160427183701.23446.15293.stgit@devbox> <20160427183752.23446.10615.stgit@devbox> MIME-Version: 1.0 In-Reply-To: <20160427183752.23446.10615.stgit@devbox> User-Agent: Mutt/1.6.0 (2016-04-01) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB07/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/04/28 11:47:54, Serialize by Router on LGEKRMHUB07/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/04/28 11:47:54, Serialize complete at 2016/04/28 11:47:54 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2101 Lines: 77 On Thu, Apr 28, 2016 at 03:37:52AM +0900, Masami Hiramatsu wrote: > From: Masami Hiramatsu > > Before analyzing debuginfo, try to find a corresponding entry > from probe cache always. This does not depend on --cache, > the --cache enables to store/update cache, but looking up > the cache is always enabled. > > Signed-off-by: Masami Hiramatsu > Signed-off-by: Masami Hiramatsu > --- [SNIP] > +static int find_probe_trace_events_from_cache(struct perf_probe_event *pev, > + struct probe_trace_event **tevs) > +{ > + struct probe_cache *cache; > + struct probe_cache_entry *entry; > + struct probe_trace_event *tev; > + struct str_node *node; > + int ret, i; > + > + cache = probe_cache__new(pev->target); > + if (!cache) > + return 0; > + > + entry = probe_cache__find(cache, pev); > + > + if (!entry && !pev->event && > + (!pev->point.file && pev->point.function && !pev->point.retprobe && > + !pev->point.line && !pev->point.offset && !pev->point.lazy_line)) { > + entry = probe_cache__find_by_name(cache, pev->group, > + pev->point.function); > + } What about arguments? It seems that it only checks group and event names of the given pev and use the cached entry's tev if found. What if they have different argument spec? Thanks, Namhyung > + if (!entry) { > + ret = 0; > + goto out; > + } > + > + ret = strlist__nr_entries(entry->tevlist); > + if (ret > probe_conf.max_probes) { > + pr_debug("Too many entries matched in the cache of %s\n", > + pev->target ? : "kernel"); > + ret = -E2BIG; > + goto out; > + } > + > + *tevs = zalloc(ret * sizeof(*tev)); > + if (!*tevs) { > + ret = -ENOMEM; > + goto out; > + } > + > + i = 0; > + strlist__for_each(node, entry->tevlist) { > + tev = &(*tevs)[i++]; > + ret = parse_probe_trace_command(node->s, tev); > + if (ret < 0) > + goto out; > + /* Set the uprobes attribute as same as original */ > + tev->uprobes = pev->uprobes; > + } > + ret = i; > + > +out: > + probe_cache__delete(cache); > + return ret; > +}