Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752203AbcD1Gaf (ORCPT ); Thu, 28 Apr 2016 02:30:35 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:55668 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751866AbcD1Gae (ORCPT ); Thu, 28 Apr 2016 02:30:34 -0400 Date: Thu, 28 Apr 2016 08:30:18 +0200 From: Sascha Hauer To: Eduardo Valentin Cc: Caesar Wang , Heiko Stuebner , dianders@chromium.org, briannorris@google.com, smbarber@google.com, linux-rockchip@lists.infradead.org, dmitry.torokhov@gmail.com, huangtao@rock-chips.com, eddie.cai@rock-chips.com, Zhang Rui , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] thermal: bang-bang governor: act on lower trip boundary Message-ID: <20160428063018.GX7860@pengutronix.de> References: <1461553367-24744-1-git-send-email-wxt@rock-chips.com> <1461553367-24744-5-git-send-email-wxt@rock-chips.com> <20160427215425.GD6438@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160427215425.GD6438@localhost.localdomain> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 07:54:35 up 51 days, 8:54, 42 users, load average: 0.02, 0.04, 0.05 User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1037 Lines: 23 On Wed, Apr 27, 2016 at 02:54:26PM -0700, Eduardo Valentin wrote: > On Mon, Apr 25, 2016 at 11:02:47AM +0800, Caesar Wang wrote: > > From: Sascha Hauer > > > > With interrupt driven thermal zones we pass the lower and upper > > temperature on which shall be acted, so in the governor we have to act on > > the exact lower temperature to be consistent. Otherwise an interrupt maybe > > generated on the exact lower temperature, but the bang bang governor does > > not react. > > What is the expected impact on polling driven zones that use bang bang > after this change? Polling driven zones may have to be one step cooler before the governor reacts, otherwise the behaviour should be unaffected. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |