Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752135AbcD1Hyc (ORCPT ); Thu, 28 Apr 2016 03:54:32 -0400 Received: from mga03.intel.com ([134.134.136.65]:39480 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750845AbcD1Hya (ORCPT ); Thu, 28 Apr 2016 03:54:30 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,546,1455004800"; d="scan'208";a="693596570" From: "Chen, Yu C" To: "Rafael J. Wysocki" , "Zheng, Lv" CC: Lv Zheng , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "Wysocki, Rafael J" , "Brown, Len" Subject: RE: [PATCH v2 4/6] ACPI / osi: Fix default _OSI(Darwin) support Thread-Topic: [PATCH v2 4/6] ACPI / osi: Fix default _OSI(Darwin) support Thread-Index: AQHRoGJ/QFM3eHmXeEy1u00Qs4rUZZ+dkT9ggAA+UoCAATWD8A== Date: Thu, 28 Apr 2016 07:54:24 +0000 Message-ID: <36DF59CE26D8EE47B0655C516E9CE640287485D3@shsmsx102.ccr.corp.intel.com> References: <36DF59CE26D8EE47B0655C516E9CE64028748233@shsmsx102.ccr.corp.intel.com> <2223787.tzTyTqLAjo@vostro.rjw.lan> In-Reply-To: <2223787.tzTyTqLAjo@vostro.rjw.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjA4OGRlZTYtMWEwZS00OTZiLWFkNjItNDA5N2YyMDA1MDg1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkU1bzhqTWNsb0pPYXlLNFEyRmtQTnFsUGordzZyN2pnR2tVTjUwS1BhSHc9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u3S7scSn023931 Content-Length: 2001 Lines: 50 Hi > -----Original Message----- > From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net] > Sent: Thursday, April 28, 2016 5:25 AM > To: Chen, Yu C; Zheng, Lv > Cc: Lv Zheng; linux-kernel@vger.kernel.org; linux-acpi@vger.kernel.org; > Wysocki, Rafael J; Brown, Len > Subject: Re: [PATCH v2 4/6] ACPI / osi: Fix default _OSI(Darwin) support > > On Wednesday, April 27, 2016 09:45:21 AM Chen, Yu C wrote: > > Hi Lv, > > > > > -----Original Message----- > > > From: Zheng, Lv > > > Sent: Wednesday, April 27, 2016 4:55 PM > > > To: Wysocki, Rafael J; Rafael J. Wysocki; Brown, Len > > > Cc: Zheng, Lv; Lv Zheng; linux-kernel@vger.kernel.org; linux- > > > acpi@vger.kernel.org; Chen, Yu C > > > Subject: [PATCH v2 4/6] ACPI / osi: Fix default _OSI(Darwin) support > > > > > > From: Chen Yu > > > > > > The following commit always reports positive value when Apple > > > hardware queries _OSI("Darwin"): > > > Commit: 7bc5a2bad0b8d9d1ac9f7b8b33150e4ddf197334 > > > Subject: ACPI: Support _OSI("Darwin") correctly However since this > > > implementation places the judgement in runtime, it breaks > > > acpi_osi=!Darwin and cannot return unsupported for _OSI("WinXXX") > > > invoked before invoking _OSI("Darwin"). > > > > > > This patch fixes the issues by reverting the wrong support and > > > implementing the default behavior of _OSI("Darwin")/_OSI("WinXXX") > > > on Apple hardware via DMI matching. > > > > > > Fixes: 7bc5a2bad0b8 ("ACPI: Support _OSI("Darwin") correctly") > > > Cc: # 3.18+ > > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=92111 > > > Reported-by: Lukas Wunner > > > Signed-off-by: Chen Yu > > > Signed-off-by: Lv Zheng > > The vendor id should be 'Apple Inc.' and 'Apple Computer, Inc.' instead. > > If this is the only problem with this patch, I can fix it up. No need to resend. Yes, this is the only problem, please help fix it, thanks! > > Thanks, > Rafael