Date: Thu, 28 Apr 2016 10:49:54 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Mike Travis <travis@sgi.com>
Cc: Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        Len Brown <len.brown@intel.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, uv4-kernel@sgi.com,
        Dimitri Sivanich <sivanich@sgi.com>
Subject: Re: [PATCH 20/21] X86_64, UV: Remove Obsolete GRU MMR address
 translation
Message-ID: <20160428084954.GC16679@gmail.com>
References: <20160428005457.471061412@asylum.americas.sgi.com>
 <20160428005500.974616236@asylum.americas.sgi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160428005500.974616236@asylum.americas.sgi.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 853
Lines: 25


* Mike Travis <travis@sgi.com> wrote:

>  	/*
> +	 * Send a noop message in order to deliver a cross-partition interrupt
> +	 * to the SSI that contains the target message queue. Normally, the
> +	 * interrupt is automatically delivered by hardware following mesq
> +	 * operations, but some error conditions require explicit delivery.
> +	 * The noop message will trigger delivery. Otherwise partition failures
>  	 * could cause unrecovered errors.
>  	 */

This is a properly structured comment.

> +		/* Don't indicate to the app to resend the message, as it's */
> +		/* already been successfully sent.  We simply send an OK */
> +		/* (rather than fail the send with MQE_UNEXPECTED_CB_ERR), */
> +		/* assuming that the other side is receiving enough */
> +		/* interrupts to get this message processed anyway. */

This is not...

Thanks,

	Ingo