Date: Thu, 28 Apr 2016 10:55:04 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Mike Travis <travis@sgi.com>
Cc: Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        Len Brown <len.brown@intel.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, uv4-kernel@sgi.com
Subject: Re: [PATCH 16/21] X86_64, UV: Add obtaining GAM Range Table from UV
 BIOS
Message-ID: <20160428085504.GD16679@gmail.com>
References: <20160428005457.471061412@asylum.americas.sgi.com>
 <20160428005500.259342623@asylum.americas.sgi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160428005500.259342623@asylum.americas.sgi.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 846
Lines: 30


* Mike Travis <travis@sgi.com> wrote:

> +	if (uv_systab->revision >= UV_SYSTAB_VERSION_UV4) {
> +		iounmap(uv_systab);
> +		uv_systab = (struct uv_systab *)
> +				ioremap(efi.uv_systab, uv_systab->size);
> +		if (!uv_systab) {
> +			pr_err("UV: UVsystab: ioremap(%d) failed!\n",
> +				uv_systab->size);
> +			return;
> +		}
> +	}
> +	pr_info("UV: UVsystab: Revision:%x\n", uv_systab->revision);

So your series in general has a lot of ugly line breaks in them, which suggests 
you took checkpatch.pl output too literally. Many of the linebreaks seem 
unnecessary, such as tihs cast:.

> +		uv_systab = (struct uv_systab *)
> +				ioremap(efi.uv_systab, uv_systab->size);

as ioremap() returns void * so it ought to be fine to just leave out the type 
cast?

etc. Please review the rest of the series for such details as well.

Thanks,

	Ingo