Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752910AbcD1Lyb (ORCPT ); Thu, 28 Apr 2016 07:54:31 -0400 Received: from e28smtp09.in.ibm.com ([125.16.236.9]:41386 "EHLO e28smtp09.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752149AbcD1Ly3 (ORCPT ); Thu, 28 Apr 2016 07:54:29 -0400 X-IBM-Helo: d28dlp01.in.ibm.com X-IBM-MailFrom: xinhui@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Message-ID: <5721E437.8050900@linux.vnet.ibm.com> Date: Thu, 28 Apr 2016 18:21:43 +0800 From: Pan Xinhui User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Peter Zijlstra CC: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, boqun.feng@gmail.com, paulmck@linux.vnet.ibm.com, tglx@linutronix.de Subject: Re: [PATCH V4] powerpc: Implement {cmp}xchg for u8 and u16 References: <5715D04E.9050009@linux.vnet.ibm.com> <571782F0.2020201@linux.vnet.ibm.com> <5720837D.6050807@linux.vnet.ibm.com> <20160428075913.GT3430@twins.programming.kicks-ass.net> In-Reply-To: <20160428075913.GT3430@twins.programming.kicks-ass.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16042811-0041-0000-0000-00000C6FD555 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 656 Lines: 23 On 2016年04月28日 15:59, Peter Zijlstra wrote: > On Wed, Apr 27, 2016 at 05:16:45PM +0800, Pan Xinhui wrote: >> From: Pan Xinhui >> >> Implement xchg{u8,u16}{local,relaxed}, and >> cmpxchg{u8,u16}{,local,acquire,relaxed}. >> >> It works on all ppc. >> >> remove volatile of first parameter in __cmpxchg_local and __cmpxchg >> >> Suggested-by: Peter Zijlstra (Intel) >> Signed-off-by: Pan Xinhui > > Generally has the right shape; and I trust others to double check the > ppc-asm minutia. > > Acked-by: Peter Zijlstra (Intel) > > thanks!