Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752883AbcD1OvD (ORCPT ); Thu, 28 Apr 2016 10:51:03 -0400 Received: from mail-pf0-f177.google.com ([209.85.192.177]:36653 "EHLO mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752862AbcD1Ou7 (ORCPT ); Thu, 28 Apr 2016 10:50:59 -0400 Date: Thu, 28 Apr 2016 07:50:55 -0700 From: Eduardo Valentin To: Sascha Hauer Cc: Caesar Wang , Heiko Stuebner , dianders@chromium.org, briannorris@google.com, smbarber@google.com, linux-rockchip@lists.infradead.org, dmitry.torokhov@gmail.com, huangtao@rock-chips.com, eddie.cai@rock-chips.com, Zhang Rui , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] thermal: bang-bang governor: act on lower trip boundary Message-ID: <20160428145054.GC19279@localhost.localdomain> References: <1461553367-24744-1-git-send-email-wxt@rock-chips.com> <1461553367-24744-5-git-send-email-wxt@rock-chips.com> <20160427215425.GD6438@localhost.localdomain> <20160428063018.GX7860@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160428063018.GX7860@pengutronix.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1349 Lines: 29 On Thu, Apr 28, 2016 at 08:30:18AM +0200, Sascha Hauer wrote: > On Wed, Apr 27, 2016 at 02:54:26PM -0700, Eduardo Valentin wrote: > > On Mon, Apr 25, 2016 at 11:02:47AM +0800, Caesar Wang wrote: > > > From: Sascha Hauer > > > > > > With interrupt driven thermal zones we pass the lower and upper > > > temperature on which shall be acted, so in the governor we have to act on > > > the exact lower temperature to be consistent. Otherwise an interrupt maybe > > > generated on the exact lower temperature, but the bang bang governor does > > > not react. > > > > What is the expected impact on polling driven zones that use bang bang > > after this change? > > Polling driven zones may have to be one step cooler before the governor > reacts, otherwise the behaviour should be unaffected. OK. Can we add this description of the expectation of what will happen to polling driver zones in the next version? An explanation on how this has bee tested on polling driven zones it is also welcome. > > Sascha > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |