Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752603AbcD1O66 (ORCPT ); Thu, 28 Apr 2016 10:58:58 -0400 Received: from mail-db3on0072.outbound.protection.outlook.com ([157.55.234.72]:52048 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751932AbcD1O64 (ORCPT ); Thu, 28 Apr 2016 10:58:56 -0400 Authentication-Results: ucw.cz; dkim=none (message not signed) header.d=none;ucw.cz; dmarc=none action=none header.from=mellanox.com; From: Chris Metcalf Subject: Re: [PATCH] scsi: fc: force inlining of wwn conversion functions To: Arnd Bergmann , Martin Jambor References: <20160419085221.GA29087@gmail.com> <5298237.1Guzp0G04x@wuerfel> <20160427110503.GB24887@virgil.suse.cz> <4940273.pi2bWg8tAl@wuerfel> CC: "Martin K. Petersen" , James Bottomley , Josh Poimboeuf , , , Denys Vlasenko , Thomas Graf , Peter Zijlstra , David Rientjes , Andrew Morton , Ingo Molnar , Himanshu Madhani , , Jan Hubicka Message-ID: Date: Thu, 28 Apr 2016 10:58:43 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <4940273.pi2bWg8tAl@wuerfel> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [12.216.194.146] X-ClientProxiedBy: BLUPR13CA0037.namprd13.prod.outlook.com (10.160.191.47) To DB5PR05MB1688.eurprd05.prod.outlook.com (10.165.6.154) X-MS-Office365-Filtering-Correlation-Id: 8f4b85f8-242a-4ac3-eaf4-08d36f759cdf X-Microsoft-Exchange-Diagnostics: 1;DB5PR05MB1688;2:tHCQoo2WWdPj+skfTUDo8CdoJYpKpYBnw4oWVMDFx3IajnrynQb0diB+hMQZ6QauU+Lu1X5ysHjUirA8Kw9aCWo9gi8vWLFwG5/8CfsawGh5vwvNN1yA/jqlwqL3QNAwtEZ9Kb6g2zhYcUoNbV+U76BF2Y/U9V9WgM3s2CsOWUBqpcnVRth5BFXb3jzRyyYF;3:FlOUZ6yd/lzei8W94x5O4MRTfmZcl9b6I+NbSub75V9Z7t/oVGUKCUVo8cvJVv9MXoPQ3n4m1ikdqM7dEl0ejNLWeXPw28h0zIFHMxMeDYPdbbO11+v7l92yhHC+fEka X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR05MB1688; X-Microsoft-Exchange-Diagnostics: 1;DB5PR05MB1688;25:xG4VhgP1IbZgQgLx0I2f9trs/SdZ97H/z/uSOdIx7iWXfrXGpOt38QHu2Tejj7o3Io52lVCLIywI7p6OghjfnqbX9rva58YaekZbWPWChWV4qd9JrnZBrPlS4h7gLCtCwJK1ryroyxu+PrzvYbqnx4JSeqFC7iKWJVh5U57eugDE3OhO+pLqHKLE8UOKn+9/w5WmCfjZE9ar81VuEnGLulKUNGMUj7rd+wA6c4ip/Xw2qmxcFsCsKI99+4sqxZKF8FfEpPidZ6UXf/lEWVJ3nZQhEIkzpfzHzXIfD3e1Yi75mxY1bFaulSwX1sCsgUmH6nbF8UYRdDZpA+Ell0qoGISWDMLOhhzGGojLIWEvQHlcraJKKy5jdfvs2lms8SL9+WmnXkla0IyHw5YU6NNfr6O+YMPNu8S/zDqHsTUWC4aH+o5RTVUEH1sWqdo8riu+rIhfMFOqJzxJLccy6ilNg2jRgq43rUCi99H33p6p/BKajG6sX74LBpjHEscwkk0Hp9OxG+a6w1pHW7wix5UoTKx845u1idXXiCWrl3XnSZL4h8wIGE9iuuBOFQUI4Q5ZUfxWVOFwag2saXv9XaPhY65runa6mGSH6F2T10xDx77qHlzHnemqcrs3P6nrUJ86Jdrg1uMq2w3tEqhrt8Hb1+/OQPMqU2MWXLjezAqVwI5H8TUeQEgdVZM1j4Qxdx4g6fMtwX6SUT1d7X178EbQRQpihHVAY/wYTUHfHWabAegpPmedtyPSLqO01ObJPUxN X-Microsoft-Exchange-Diagnostics: 1;DB5PR05MB1688;20:nXc2fF7Udr59iWHcaantK72+e6PRkwEGg3rBhxzbvy988JsJhXzgDgaqlCG/jxeq8cClLx6DyCcZqSbokNjMDm4tuNX6FwwQcc0FMQGScOPiGL8JE8Gu3OsUB+vhtHt+R6Kvi+GAMKwinuBStxj8tS2GOgEo9cz69g8YXYw1jSmcjpaVaguADPlsh4lpLOM22Que5R9CnylYwgBdSz7alMs2QBS4+K1lExPmKnrCA1KdLJ3F9FuQd+nrL3UHegyOl0VRsEzLAt8AMw2SU8sb48S4QA37L6PosrMb4VDd3uqOw1I7ud0FhhVyR2qyE8vj+stEtEiA+gU2ejgntmksXLCJMDYHUG/pRbP2G7I0tKCgqYkCXhW4KtUHcb9THGYsAAObI82rdwVaqFFI2l4Ho3xJIvMVyHomfmp/sIlSQLO60bdsnBbHkPiqunwVdUYyXiro9pFMmUJypVbm0bNDglcEdeKN+/WnlvE4LOzpi9Up14Gj1u5ZbMv7U5mzMEMd;4:WlFjUSski9EZvq7fNhJpLJVhr/Bws5MCymISXwPj05zR6Yo+plGPXAjHEB71offecpI0fGqvwGh2f1pIC1qTilMT+AlSp4iHTBjKtyPCDORQXK/FMgP83s8sz/+RvOcxzquJBTxztLvFz1tjC9WS/+02S730NSzJaUVF40MqXReMMlreQ/7GZq1El5r7qT6jnMKgd64q+TZUKjqrvstd9KDqE7aBsE5M+ZuXI+PXPUQNRflot5czMjBnINVPYJntOFU2TQGAq7+vkgcW+yhnwahm6RML+pecywEAebyR3LMNBpI7xb/y0z1OqbFGHwWcOB79wxxe8u7zCwkdj6ZUrrdj5gMSKT07tnecQdd1+PD2K3hF1stlUufKkfT7H1nZWssZ2RjO1eupR+AzsX4Tb1djZqM2UKm0W7dXtXuMpAs= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(9101521072)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:DB5PR05MB1688;BCL:0;PCL:0;RULEID:;SRVR:DB5PR05MB1688; X-Forefront-PRVS: 0926B0E013 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(24454002)(377454003)(4001350100001)(19580395003)(1096002)(5008740100001)(33646002)(50986999)(2950100001)(54356999)(5004730100002)(31696002)(92566002)(64126003)(4326007)(230700001)(76176999)(65806001)(65956001)(83506001)(66066001)(93886004)(189998001)(2906002)(23746002)(81166005)(36756003)(47776003)(77096005)(586003)(50466002)(15975445007)(3846002)(6116002)(42186005)(86362001)(5001770100001)(65826006)(18886065003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB5PR05MB1688;H:[10.15.7.169];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DB5PR05MB1688;23:NXdGh6eFjR8S49To+KoMlrYFe6kyQYWRoTrOf?= =?Windows-1252?Q?Qn19J+zsO7jeBFKAsL67nsut7odw9sCA3vOBgEyhjIIa3xrWihzJb/FF?= =?Windows-1252?Q?wc2rWO9zWcfZrDxmsxcjuYzwidjmUvWd4mE1TKn+E8099pnvtHFdMg/Y?= =?Windows-1252?Q?jbkfwwxH5kQIoTE4izNS8LKZ/jbsfyuMf3gHFZ2sfZDJBsqp3coY+1BG?= =?Windows-1252?Q?ChMTNujIuNTRJO4AuCMSssn5rwHw1/eaFvdBNBZog4Ruv8y/Tu8Bmox2?= =?Windows-1252?Q?2PrUf7hJuazuYTDX3shkH8pYXcWyDpRwhKf03243u8lgrHNVxIh9y0S9?= =?Windows-1252?Q?IkEz/2t24hKInWFZuvSjkowxHronlMqF6HmvtbDwIcJXhScaEcpWCAMK?= =?Windows-1252?Q?YvGGL1S5J/jQchOUsBaNNMJQcG5ICwNkglfpMnN2W20CB/OJaelTIV9P?= =?Windows-1252?Q?zBlYIeo/rQM4p3MnEL3m5e5kL1ytsFe+/sqYJSx8nm8XBl92uCBuLssc?= =?Windows-1252?Q?aIwOL65VV9yTuFXoC9KJJkXcn+eexkDDdEC8rQSdeWq2Jb6MoZP/8A8D?= =?Windows-1252?Q?RCDMjmOMzvZ8lPyV8CXsEznaTD8JuvloGZ0DaT+x2zwov/9YrPoVz3+a?= =?Windows-1252?Q?6WLNNdQmi3lMjTLpFn1VFTptCNonWSgiwYgG8T5bp1qnxcxJAZeN3el3?= =?Windows-1252?Q?QkcsqIB9qI3cdQYIDp+DYiB1WuixjNwTRDhQQazCkoKj4tTyAoAnrFSq?= =?Windows-1252?Q?65UloCIXbN1nWwbM/4A5c3Terrp1kOVA1HOs9TuEBvsSOh3uF9jIDmFJ?= =?Windows-1252?Q?WkuRg4zLyr/Pa71Oks3oCFEFouW0QNDKUunTSa3rST791Knu0FYZYLtF?= =?Windows-1252?Q?i/cJTgXTHkPCWRrKuJrD2I2SSLmvcubMUhT1wi35UDIqpp9CvM5gkpK+?= =?Windows-1252?Q?YJWJdFRqryW3thd1+4xk2TthDBp2AHqqRcoVrFJ9mQ/0i08nFKAWAvYw?= =?Windows-1252?Q?i59h6cZvmP10BX/8gR8/rOHyTbRhdF32/oibUoMxfniJUZEaHF3+2ua9?= =?Windows-1252?Q?pwTtphiE56/ZU4asgSR/4hgeAJV0kUujbCpNhO8vLRiWSuCO256thF0k?= =?Windows-1252?Q?RSCUKL1ANxlazGVt6YZJ2Pnp0RFVIwaqvhZZfwQqAExsS8xirSJ+lji5?= =?Windows-1252?Q?ueXpX9g/LGRLKJLBxeAS3YJpzFvZvs=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB5PR05MB1688;5:EbhneHJNuze7rKEQ2OZxaVyVy1tFlAR3XbP6O1Hneta/zoJ3fwC0c9zkNFqtyuF93RVxXaqv60qGk2MrOzDOh0Mv9LMSvq5DK4v1ny+0GnfV/6MpeZiFPhP5j04lCEgx0zksyoM7j9lHjsq2vz5Kwg==;24:hL4gIyxfiuDqIj8WmHms+QueAow3d1PFj82N2g5HPpMhvIIjvVc1ldifc3y27XUMXRF7pn8BYag4hyUVp0zrr7j31VrRMBkUhvju2xnGRQI=;7:NETyG4QZj+EiHm4VKiqhVxg7HIPFs5qTwJrIWupc/H4avGhd/yhcEMIeLLqtjjzUKRwqTzNLp1oh+pwX/G2hlJa+JXJLDbsnfDMwg332RyL9UW14PmOBuaQ+BMgYoYOuq+mspJmpgmlzqp1UhKQGcFNnc34Hg217sKytxrbLYcGpvkrQQ4LY/1tZRxg33wD6 SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2016 14:58:50.4710 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR05MB1688 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1037 Lines: 22 (Resending as text/plain) On 4/27/2016 5:34 PM, Arnd Bergmann wrote: > This won't help on TILE, which is the one architecture that sets > ARCH_SUPPORTS_OPTIMIZED_INLINING but does not set ARCH_USE_BUILTIN_BSWAP. > Chris Metcalf should be able to figure out whether we can just > set ARCH_USE_BUILTIN_BSWAP for tile as well. We certainly could enable ARCH_USE_BUILTIN_BSWAP. The only problem is that we never added explicit support for bswap16() in gcc, which is efficiently done on tilegx via the "revbytes" instruction and a 48-bit right-shift. So gcc instead does a generic thing with four instructions in three bundles, so really not as good as our asm/swab.h. I'm not sure how to weigh the implications of converting to builtin_bswap16 (and possibly upstreaming a better implementation to gcc), vs. disabling ARCH_SUPPORTS_OPTIMIZED_INLINING (which no one else but x86 uses anyway), vs. just ignoring the compiler bug and hoping it's not an issue in practice :-) -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com