Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753092AbcD1Phl (ORCPT ); Thu, 28 Apr 2016 11:37:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49138 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753001AbcD1Phd (ORCPT ); Thu, 28 Apr 2016 11:37:33 -0400 Date: Thu, 28 Apr 2016 11:37:31 -0400 From: Mike Snitzer To: Michal Hocko Cc: Andrew Morton , Michal Hocko , LKML , linux-mm@kvack.org, dm-devel@redhat.com, Mikulas Patocka , Shaohua Li Subject: Re: [PATCH 19/20] md: simplify free_params for kmalloc vs vmalloc fallback Message-ID: <20160428153730.GA14570@redhat.com> References: <1461849846-27209-1-git-send-email-mhocko@kernel.org> <1461849846-27209-20-git-send-email-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461849846-27209-20-git-send-email-mhocko@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 548 Lines: 16 On Thu, Apr 28 2016 at 9:24am -0400, Michal Hocko wrote: > From: Michal Hocko > > Use kvfree rather than DM_PARAMS_[KV]MALLOC specific param flags. > > Cc: Shaohua Li > Cc: Mikulas Patocka > Cc: dm-devel@redhat.com > Signed-off-by: Michal Hocko Nack, seriously, this is the 3rd time this patch has been attempted. Did you actually test the change? It'll crash very quickly, see: https://www.redhat.com/archives/dm-devel/2016-April/msg00103.html