Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752976AbcD1QAZ (ORCPT ); Thu, 28 Apr 2016 12:00:25 -0400 Received: from mail-wm0-f54.google.com ([74.125.82.54]:37178 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752659AbcD1QAY (ORCPT ); Thu, 28 Apr 2016 12:00:24 -0400 Date: Thu, 28 Apr 2016 18:00:21 +0200 From: Michal Hocko To: Mike Snitzer Cc: Andrew Morton , LKML , linux-mm@kvack.org, dm-devel@redhat.com, Mikulas Patocka , Shaohua Li Subject: Re: [PATCH 19/20] md: simplify free_params for kmalloc vs vmalloc fallback Message-ID: <20160428160021.GN31489@dhcp22.suse.cz> References: <1461849846-27209-1-git-send-email-mhocko@kernel.org> <1461849846-27209-20-git-send-email-mhocko@kernel.org> <20160428153730.GA14570@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160428153730.GA14570@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 718 Lines: 23 On Thu 28-04-16 11:37:31, Mike Snitzer wrote: > On Thu, Apr 28 2016 at 9:24am -0400, > Michal Hocko wrote: > > > From: Michal Hocko > > > > Use kvfree rather than DM_PARAMS_[KV]MALLOC specific param flags. > > > > Cc: Shaohua Li > > Cc: Mikulas Patocka > > Cc: dm-devel@redhat.com > > Signed-off-by: Michal Hocko > > Nack, seriously, this is the 3rd time this patch has been attempted. > Did you actually test the change? It'll crash very quickly, see: > > https://www.redhat.com/archives/dm-devel/2016-April/msg00103.html You are right! My bad I should have checked the other callers! -- Michal Hocko SUSE Labs