Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S261542AbTCZKef>; Wed, 26 Mar 2003 05:34:35 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S261545AbTCZKef>; Wed, 26 Mar 2003 05:34:35 -0500
Received: from mail2.sonytel.be ([195.0.45.172]:23690 "EHLO mail.sonytel.be")
	by vger.kernel.org with ESMTP id <S261542AbTCZKee>;
	Wed, 26 Mar 2003 05:34:34 -0500
Date: Wed, 26 Mar 2003 11:45:34 +0100 (MET)
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Andries.Brouwer@cwi.nl
cc: Linux Kernel Development <linux-kernel@vger.kernel.org>,
       Linus Torvalds <torvalds@transmeta.com>,
       Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: Linux 2.5.66
In-Reply-To: <UTC200303250551.h2P5pXU11604.aeb@smtp.cwi.nl>
Message-ID: <Pine.GSO.4.21.0303261142390.20738-100000@vervain.sonytel.be>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1382
Lines: 38

On Tue, 25 Mar 2003 Andries.Brouwer@cwi.nl wrote:
> Good! But I don't see my compilation fixes. Will resend.
> Below a new one.
> 
> Andries
> 
> diff -u --recursive --new-file -X /linux/dontdiff a/fs/partitions/msdos.c b/fs/partitions/msdos.c
> --- a/fs/partitions/msdos.c	Mon Feb 24 23:02:56 2003
> +++ b/fs/partitions/msdos.c	Tue Mar 25 06:22:31 2003
> @@ -219,7 +219,7 @@
>   * Create devices for BSD partitions listed in a disklabel, under a
>   * dos-like partition. See parse_extended() for more information.
>   */
> -static void
> +void
>  parse_bsd(struct parsed_partitions *state, struct block_device *bdev,
>  		u32 offset, u32 size, int origin, char *flavour,
>  		int max_partitions)

Doesn't it make sense to move parse_bsd() to a separate file? Else we have to
add a dependency on MSDOS_PARTITION to NEC98_PARTITION.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/