Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752517AbcD1Rzl (ORCPT ); Thu, 28 Apr 2016 13:55:41 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:49065 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751657AbcD1Rzj convert rfc822-to-8bit (ORCPT ); Thu, 28 Apr 2016 13:55:39 -0400 Date: Thu, 28 Apr 2016 14:55:25 -0300 From: Gustavo Padovan To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: Daniel Vetter , Gustavo Padovan , Daniel Stone , Greg Hackmann , Daniel Stone , Riley Andrews , dri-devel , Linux Kernel Mailing List , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , John Harrison Subject: Re: [RFC v2 5/8] drm/fence: add in-fences support Message-ID: <20160428175525.GA3502@joana> References: <20160426174045.GC4329@intel.com> <20160426182346.GC2558@phenom.ffwll.local> <20160426185506.GH4329@intel.com> <20160426200505.GD2558@phenom.ffwll.local> <571FD402.6050407@google.com> <20160428143644.GA3496@joana> <20160428165619.GD4329@intel.com> <20160428175124.GG4329@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20160428175124.GG4329@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 992 Lines: 23 2016-04-28 Ville Syrj?l? : > On Thu, Apr 28, 2016 at 07:43:16PM +0200, Daniel Vetter wrote: > > On Thu, Apr 28, 2016 at 6:56 PM, Ville Syrj?l? > > wrote: > > >> - better for tracing, can identify the buffer/fence promptly > > > > > > Can fences be reused somehow while still attached to a plane, or ever? > > > That might cause some oddness if you, say, leave a fence attached to one > > > plane and then do a modeset on another crtc perhaps which needs to turn > > > the first crtc off+on to reconfigure something. > > > > Fences auto-disappear of course and don't stick around when you > > duplicate the drm_plane_state again. I still don't really get the real > > concerns though ... > > Properties that magically change values shouldn't exist IMO. I guess if > you could have write-only properties or something it migth be sensible? We can just not return FENCE_FD on get_props, that would make it write-only. Gustavo