Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752330AbcD1S3n (ORCPT ); Thu, 28 Apr 2016 14:29:43 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:33602 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751513AbcD1S3l (ORCPT ); Thu, 28 Apr 2016 14:29:41 -0400 Date: Thu, 28 Apr 2016 11:29:38 -0700 From: Brian Norris To: Jianqun Xu , Heiko Stuebner Cc: mark.rutland@arm.com, huangtao@rock-chips.com, davidriley@chromium.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, dianders@chromium.org, smbarber@chromium.org, lintao@rock-chips.com, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, galak@codeaurora.org, jwerner@chromium.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/4] ARM64: dts: rockchip: add core dtsi file for RK3399 SoCs Message-ID: <20160428182938.GA3079@google.com> References: <1461743693-10671-1-git-send-email-jay.xu@rock-chips.com> <1461743693-10671-3-git-send-email-jay.xu@rock-chips.com> <20160428160353.GA95284@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160428160353.GA95284@google.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1099 Lines: 32 One more thing: On Thu, Apr 28, 2016 at 09:03:53AM -0700, Brian Norris wrote: > Hi Heiko, Jianqun, > > On Wed, Apr 27, 2016 at 03:54:51PM +0800, Jianqun Xu wrote: > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > > new file mode 100644 > > index 0000000..5a8a915 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > > @@ -0,0 +1,1022 @@ > [...] > > + sdhci: sdhci@fe330000 { > > + compatible = "rockchip,rk3399-sdhci-5.1", "arasan,sdhci-5.1"; > > Not to rain on the parade too much, as this is already applied, but is > the "rockchip,rk3399-sdhci-5.1" string documented anywhere? I don't see > it. According to the latest binding for "arasan,sdhci-5.1", the "phy" and "phy-names" properties are required. Fortunately, this device stays "disabled" for now in your EVB DTS. But just FYI. > > + reg = <0x0 0xfe330000 0x0 0x10000>; > > + interrupts = ; > > + clocks = <&cru SCLK_EMMC>, <&cru ACLK_EMMC>; > > + clock-names = "clk_xin", "clk_ahb"; > > + status = "disabled"; > > + }; Brian