Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753045AbcD1TwN (ORCPT ); Thu, 28 Apr 2016 15:52:13 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:41412 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751865AbcD1TwK (ORCPT ); Thu, 28 Apr 2016 15:52:10 -0400 Date: Thu, 28 Apr 2016 15:52:07 -0400 (EDT) Message-Id: <20160428.155207.1419062437411480208.davem@davemloft.net> To: narmstrong@baylibre.com Cc: andrew@lunn.ch, thomas.lendacky@amd.com, mugunthanvnm@ti.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, b.hutchman@gmail.com Subject: Re: [PATCH] net: ethernet: davinci_emac: Fix devioctl while in fixed link From: David Miller In-Reply-To: <1461606098-20057-1-git-send-email-narmstrong@baylibre.com> References: <1461606098-20057-1-git-send-email-narmstrong@baylibre.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 28 Apr 2016 12:52:09 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 458 Lines: 12 From: Neil Armstrong Date: Mon, 25 Apr 2016 19:41:38 +0200 > When configured in fixed link, the DaVinci emac driver sets the > priv->phydev to NULL and further ioctl calls to the phy_mii_ioctl() > causes the kernel to crash. > > Cc: Brian Hutchinson > Fixes: 1bb6aa56bb38 ("net: davinci_emac: Add support for fixed-link PHY") > Signed-off-by: Neil Armstrong Applied, thanks Neil.