Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753179AbcD1U3j (ORCPT ); Thu, 28 Apr 2016 16:29:39 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:41923 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752522AbcD1U3h (ORCPT ); Thu, 28 Apr 2016 16:29:37 -0400 Date: Thu, 28 Apr 2016 16:29:35 -0400 (EDT) Message-Id: <20160428.162935.1502512352683455462.davem@davemloft.net> To: colin.king@canonical.com Cc: vivien.didelot@savoirfairelinux.com, andrew@lunn.ch, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: dsa: mv88e6xxx: fix uninitialized error return From: David Miller In-Reply-To: <1461622282-30463-1-git-send-email-colin.king@canonical.com> References: <1461622282-30463-1-git-send-email-colin.king@canonical.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 28 Apr 2016 13:29:37 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 419 Lines: 13 From: Colin King Date: Mon, 25 Apr 2016 23:11:22 +0100 > From: Colin Ian King > > The error return err is not initialized and there is a possibility > that err is not assigned causing mv88e6xxx_port_bridge_join to > return a garbage error return status. Fix this by initializing err > to 0. > > Signed-off-by: Colin Ian King Applied.