Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753843AbcD1Uvg (ORCPT ); Thu, 28 Apr 2016 16:51:36 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:47125 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753285AbcD1Uvd (ORCPT ); Thu, 28 Apr 2016 16:51:33 -0400 Date: Thu, 28 Apr 2016 13:51:32 -0700 From: Greg Kroah-Hartman To: Frank Rowand Cc: Andy Gross , David Brown , Jiri Slaby , "linux-arm-msm@vger.kernel.org" , linux-soc@vger.kernel.org, linux-serial@vger.kernel.org, Linux Kernel list , ivan.ivanov@linaro.org Subject: Re: [PATCH 2/2] tty: serial: msm_serial add info message Message-ID: <20160428205132.GA22117@kroah.com> References: <571BAC8B.80001@gmail.com> <571BAE11.3020706@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <571BAE11.3020706@gmail.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 829 Lines: 26 On Sat, Apr 23, 2016 at 10:17:05AM -0700, Frank Rowand wrote: > From: Frank Rowand > > Failure to enable DMA by the msm_serial driver is silent. > Add a message to report the failure. > > Signed-off-by: Frank Rowand > --- > drivers/tty/serial/msm_serial.c | 1 + > 1 file changed, 1 insertion(+) > > Index: b/drivers/tty/serial/msm_serial.c > =================================================================== > --- a/drivers/tty/serial/msm_serial.c > +++ b/drivers/tty/serial/msm_serial.c > @@ -170,6 +170,7 @@ rel_tx: > dma_release_channel(dma->chan); > no_tx: > memset(dma, 0, sizeof(*dma)); > + dev_info(dev, "msm_serial: DMA not enabled\n"); Don't print out messages that a user can't do something with :( So I agree, this is not needed, sorry. greg k-h