Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753625AbcD1VMg (ORCPT <rfc822;w@1wt.eu>);
	Thu, 28 Apr 2016 17:12:36 -0400
Received: from comal.ext.ti.com ([198.47.26.152]:34460 "EHLO comal.ext.ti.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753492AbcD1VMe (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 28 Apr 2016 17:12:34 -0400
Subject: Re: [PATCH v7 2/9] ARM: dts: am437x: Add missing compatibles to PWM
 binding documents
To: Rob Herring <robh@kernel.org>
References: <1461710209-6563-1-git-send-email-fcooper@ti.com>
 <1461710209-6563-3-git-send-email-fcooper@ti.com>
 <20160428210716.GA12508@rob-hp-laptop>
CC: <thierry.reding@gmail.com>, <tony@atomide.com>, <paul@pwsan.com>,
        <t-kristo@ti.com>, <linux-pwm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-omap@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        <linux-clk@vger.kernel.org>, <vigneshr@ti.com>, <nsekhar@ti.com>
From: "Franklin S Cooper Jr." <fcooper@ti.com>
Message-ID: <57227C9F.6080705@ti.com>
Date: Thu, 28 Apr 2016 16:11:59 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <20160428210716.GA12508@rob-hp-laptop>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3532
Lines: 84


Rob,
On 04/28/2016 04:07 PM, Rob Herring wrote:
> On Tue, Apr 26, 2016 at 05:36:42PM -0500, Franklin S Cooper Jr wrote:
>> There are several SOC specific compatibles for ECAP, EHRPWM and PWMMS
>> that are in use but aren't properly documented. Therefore, fix this
>> by adding the compatibles to the appropriate binding documents.
>>
>> While at it make minor corrections to the binding document.
>>
>> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
>> ---
>>  .../devicetree/bindings/pwm/pwm-tiecap.txt          | 12 ++++++++++--
>>  .../devicetree/bindings/pwm/pwm-tiehrpwm.txt        | 12 ++++++++++--
>>  .../devicetree/bindings/pwm/pwm-tipwmss.txt         | 21 +++++++++++++++++++--
>>  3 files changed, 39 insertions(+), 6 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
>> index fb81179..788da6c 100644
>> --- a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
>> +++ b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
>> @@ -2,8 +2,9 @@ TI SOC ECAP based APWM controller
>>  
>>  Required properties:
>>  - compatible: Must be "ti,<soc>-ecap".
>> -  for am33xx - compatible = "ti,am33xx-ecap";
>> -  for da850  - compatible = "ti,da850-ecap", "ti,am33xx-ecap";
>> +  for am33xx  - compatible = "ti,am33xx-ecap";
>> +  for am4372  - compatible = "ti,am4372-ecap", "ti,am33xx-ecap";
>> +  for da850   - compatible = "ti,da850-ecap", "ti,am33xx-ecap";
>>  - #pwm-cells: should be 3. See pwm.txt in this directory for a description of
>>    the cells format. The PWM channel index ranges from 0 to 4. The only third
>>    cell flag supported by this binding is PWM_POLARITY_INVERTED.
>> @@ -22,6 +23,13 @@ ecap0: ecap@0 { /* ECAP on am33xx */
>>  	ti,hwmods = "ecap0";
>>  };
>>  
>> +ecap0: ecap@0 { /* ECAP on am4372 */
> 
> The unit address is wrong.
> 
>> +	compatible = "ti,am4372-ecap", "ti,am33xx-ecap";
>> +	#pwm-cells = <3>;
>> +	reg = <0x48300100 0x80>;
>> +	ti,hwmods = "ecap0";
>> +};
>> +
>>  ecap0: ecap@0 { /* ECAP on da850 */
>>  	compatible = "ti,da850-ecap", "ti,am33xx-ecap";
>>  	#pwm-cells = <3>;
>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt b/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
>> index 9c100b2..99b544f 100644
>> --- a/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
>> +++ b/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
>> @@ -2,8 +2,9 @@ TI SOC EHRPWM based PWM controller
>>  
>>  Required properties:
>>  - compatible: Must be "ti,<soc>-ehrpwm".
>> -  for am33xx - compatible = "ti,am33xx-ehrpwm";
>> -  for da850  - compatible = "ti,da850-ehrpwm", "ti,am33xx-ehrpwm";
>> +  for am33xx  - compatible = "ti,am33xx-ehrpwm";
>> +  for am4372  - compatible = "ti,am4372-ehrpwm", "ti,am33xx-ehrpwm";
>> +  for da850   - compatible = "ti,da850-ehrpwm", "ti,am33xx-ehrpwm";
>>  - #pwm-cells: should be 3. See pwm.txt in this directory for a description of
>>    the cells format. The only third cell flag supported by this binding is
>>    PWM_POLARITY_INVERTED.
>> @@ -22,6 +23,13 @@ ehrpwm0: ehrpwm@0 { /* EHRPWM on am33xx */
>>  	ti,hwmods = "ehrpwm0";
>>  };
>>  
>> +ehrpwm0: ehrpwm@0 { /* EHRPWM on am4372 */
> 
> ditto
> 
> Otherwise,
> 
> Acked-by: Rob Herring <robh@kernel.org>
> 


Yes, the unit address is wrong but it is wrong in several places. I
added it like that to match what the other bindings are doing. However,
patches 3 and 4 fixes these unit address problems for all the bindings
all together to make things clear.