Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753629AbcD1VmF (ORCPT ); Thu, 28 Apr 2016 17:42:05 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:52726 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752780AbcD1VmD (ORCPT ); Thu, 28 Apr 2016 17:42:03 -0400 Subject: Re: [PATCH v7 4/9] pwm: pwm-tiecap: Update dt binding document to use proper unit address To: Rob Herring References: <1461710209-6563-1-git-send-email-fcooper@ti.com> <1461710209-6563-5-git-send-email-fcooper@ti.com> <20160428213122.GA27352@rob-hp-laptop> CC: , , , , , , , , , , , From: "Franklin S Cooper Jr." Message-ID: <5722838B.7070309@ti.com> Date: Thu, 28 Apr 2016 16:41:31 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160428213122.GA27352@rob-hp-laptop> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1695 Lines: 56 On 04/28/2016 04:31 PM, Rob Herring wrote: > On Tue, Apr 26, 2016 at 05:36:44PM -0500, Franklin S Cooper Jr wrote: >> Replace unit address from 0 to the proper physical address. >> >> Signed-off-by: Franklin S Cooper Jr >> --- >> Documentation/devicetree/bindings/pwm/pwm-tiecap.txt | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt >> index 788da6c..1b7eec5 100644 >> --- a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt >> +++ b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt >> @@ -16,21 +16,21 @@ Optional properties: >> >> Example: >> >> -ecap0: ecap@0 { /* ECAP on am33xx */ >> +ecap0: ecap@48300100 { /* ECAP on am33xx */ >> compatible = "ti,am33xx-ecap"; >> #pwm-cells = <3>; >> reg = <0x48300100 0x80>; >> ti,hwmods = "ecap0"; >> }; >> >> -ecap0: ecap@0 { /* ECAP on am4372 */ >> +ecap0: ecap@48300100 { /* ECAP on am4372 */ >> compatible = "ti,am4372-ecap", "ti,am33xx-ecap"; >> #pwm-cells = <3>; >> reg = <0x48300100 0x80>; >> ti,hwmods = "ecap0"; >> }; >> >> -ecap0: ecap@0 { /* ECAP on da850 */ >> +ecap0: ecap@1f06000 { /* ECAP on da850 */ >> compatible = "ti,da850-ecap", "ti,am33xx-ecap"; >> #pwm-cells = <3>; >> reg = <0x306000 0x80>; > > These still don't match. > > Rob I apologize you made a similar comment in the past but I misinterpreted it recently which is why I made the same mistake again. I'll fix it. Any issue with my response to your patch two comment for why I did things the way I did? If so I can fix it when I send my new rev. > >> -- >> 2.7.0 >>