Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752659AbcD1WP4 (ORCPT ); Thu, 28 Apr 2016 18:15:56 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:34885 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752546AbcD1WPy (ORCPT ); Thu, 28 Apr 2016 18:15:54 -0400 Message-ID: <57228B96.6090502@gmail.com> Date: Thu, 28 Apr 2016 15:15:50 -0700 From: Frank Rowand Reply-To: frowand.list@gmail.com User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Greg Kroah-Hartman CC: Andy Gross , David Brown , Jiri Slaby , "linux-arm-msm@vger.kernel.org" , linux-soc@vger.kernel.org, linux-serial@vger.kernel.org, Linux Kernel list , ivan.ivanov@linaro.org Subject: Re: [PATCH 2/2] tty: serial: msm_serial add info message References: <571BAC8B.80001@gmail.com> <571BAE11.3020706@gmail.com> <20160428205132.GA22117@kroah.com> In-Reply-To: <20160428205132.GA22117@kroah.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 963 Lines: 32 On 4/28/2016 1:51 PM, Greg Kroah-Hartman wrote: > On Sat, Apr 23, 2016 at 10:17:05AM -0700, Frank Rowand wrote: >> From: Frank Rowand >> >> Failure to enable DMA by the msm_serial driver is silent. >> Add a message to report the failure. >> >> Signed-off-by: Frank Rowand >> --- >> drivers/tty/serial/msm_serial.c | 1 + >> 1 file changed, 1 insertion(+) >> >> Index: b/drivers/tty/serial/msm_serial.c >> =================================================================== >> --- a/drivers/tty/serial/msm_serial.c >> +++ b/drivers/tty/serial/msm_serial.c >> @@ -170,6 +170,7 @@ rel_tx: >> dma_release_channel(dma->chan); >> no_tx: >> memset(dma, 0, sizeof(*dma)); >> + dev_info(dev, "msm_serial: DMA not enabled\n"); > > Don't print out messages that a user can't do something with :( > > So I agree, this is not needed, sorry. > > greg k-h > I am ok with dropping patch 2. No problem. -Frank