Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752797AbcD2CUA (ORCPT ); Thu, 28 Apr 2016 22:20:00 -0400 Received: from m97135.qiye.163.com ([220.181.97.135]:35936 "EHLO m97135.qiye.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752244AbcD2CT7 (ORCPT ); Thu, 28 Apr 2016 22:19:59 -0400 X-Greylist: delayed 398 seconds by postgrey-1.27 at vger.kernel.org; Thu, 28 Apr 2016 22:19:58 EDT From: Jandy Gou To: Larry.Finger@lwfinger.net, Jes.Sorensen@redhat.com, gregkh@linuxfoundation.org, shraddha.6596@gmail.com, hgujulan@visteon.com Cc: linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Jandy Gou Subject: [PATCH v2] staging: r8723au: This patch tries to fix some byte order issues that is found by sparse check. Date: Fri, 29 Apr 2016 10:09:11 +0800 Message-Id: <1461895751-15168-1-git-send-email-qingsong.gou@ck-telecom.com> X-Mailer: git-send-email 1.9.1 X-CM-TRANSID: h+CowECppkXQwiJXgqbEAQ--.6S3 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvj4RIfOwDUUUU X-Originating-IP: [182.150.59.104] X-CM-SenderInfo: 5tlqw2xrqjhw1rx6uywnwhzvxfrphudrp/1tbiPBJauFXJmz1NDgAAs1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1663 Lines: 48 make C=1 M=drivers/staging/rtl8723au/ drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:96:38: warning: cast to restricted __le16 drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:100:27: warning: cast to restricted __le32 Signed-off-by: Jandy Gou --- drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c b/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c index 1662c03c..fff652c 100644 --- a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c +++ b/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c @@ -56,8 +56,8 @@ int FillH2CCmd(struct rtw_adapter *padapter, u8 ElementID, u32 CmdLen, u32 msgbox_addr; u32 msgbox_ex_addr; struct hal_data_8723a *pHalData; - u32 h2c_cmd = 0; - u16 h2c_cmd_ex = 0; + __le32 h2c_cmd = 0; + __le16 h2c_cmd_ex = 0; int ret = _FAIL; padapter = GET_PRIMARY_ADAPTER(padapter); @@ -91,14 +91,12 @@ int FillH2CCmd(struct rtw_adapter *padapter, u8 ElementID, u32 CmdLen, *(u8 *)(&h2c_cmd) |= ElementID; - if (h2c_cmd & BIT(7)) { + if (le32_to_cpu(h2c_cmd) & BIT(7)) { msgbox_ex_addr = REG_HMEBOX_EXT_0 + (h2c_box_num * EX_MESSAGE_BOX_SIZE); - h2c_cmd_ex = le16_to_cpu(h2c_cmd_ex); - rtl8723au_write16(padapter, msgbox_ex_addr, h2c_cmd_ex); + rtl8723au_write16(padapter, msgbox_ex_addr, le16_to_cpu(h2c_cmd_ex)); } msgbox_addr = REG_HMEBOX_0 + (h2c_box_num * MESSAGE_BOX_SIZE); - h2c_cmd = le32_to_cpu(h2c_cmd); - rtl8723au_write32(padapter, msgbox_addr, h2c_cmd); + rtl8723au_write32(padapter, msgbox_addr, le32_to_cpu(h2c_cmd)); bcmd_down = true; -- 1.9.1