Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752327AbcD2HyJ (ORCPT ); Fri, 29 Apr 2016 03:54:09 -0400 Received: from out4133-146.mail.aliyun.com ([42.120.133.146]:38083 "EHLO out4133-146.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750752AbcD2HyI (ORCPT ); Fri, 29 Apr 2016 03:54:08 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R141e4;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e02c03305;MF=hillf.zj@alibaba-inc.com;NM=1;PH=DS;RN=2;SR=0;TI=SMTPD_----4ke.4te_1461916421; Reply-To: "Hillf Danton" From: "Hillf Danton" To: "'Gustavo Padovan'" Cc: "linux-kernel" References: <00d201d1a1eb$86be73f0$943b5bd0$@alibaba-inc.com> In-Reply-To: <00d201d1a1eb$86be73f0$943b5bd0$@alibaba-inc.com> Subject: Re: [PATCH v2 01/13] staging/android: remove redundant comments on sync_merge_data Date: Fri, 29 Apr 2016 15:53:41 +0800 Message-ID: <00d801d1a1ec$3f573a50$be05aef0$@alibaba-inc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQKWHmaf3Ug+qqIpn9IN5Xzcv6CGPJ4XmmBw Content-Language: zh-cn Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1656 Lines: 49 > > From: Gustavo Padovan > > struct sync_merge_data already have documentation on top of the > struct definition. No need to duplicate it. > > Signed-off-by: Gustavo Padovan > Reviewed-by: Maarten Lankhorst > Reviewed-by: Daniel Vetter > --- > drivers/staging/android/uapi/sync.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/android/uapi/sync.h b/drivers/staging/android/uapi/sync.h > index 7de5d6a..413303d 100644 > --- a/drivers/staging/android/uapi/sync.h > +++ b/drivers/staging/android/uapi/sync.h > @@ -23,9 +23,9 @@ > * @pad: padding for 64-bit alignment, should always be zero > */ > struct sync_merge_data { > - char name[32]; /* name of new fence */ > - __s32 fd2; /* fd of second fence */ > - __s32 fence; /* fd on newly created fence */ > + char name[32]; > + __s32 fd2; > + __s32 fence; > __u32 flags; > __u32 pad; > }; > @@ -33,8 +33,8 @@ struct sync_merge_data { > /** > * struct sync_fence_info - detailed fence information > * @obj_name: name of parent sync_timeline > - * @driver_name: name of driver implementing the parent > - * @status: status of the fence 0:active 1:signaled <0:error > +* @driver_name: name of driver implementing the parent > +* @status: status of the fence 0:active 1:signaled <0:error Would you please specify why this hunk is needed, with fence info not mentioned in commit message? > * @flags: fence_info flags > * @timestamp_ns: timestamp of status change in nanoseconds > */ > -- > 2.5.5 >