Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752795AbcD2IbI (ORCPT ); Fri, 29 Apr 2016 04:31:08 -0400 Received: from down.free-electrons.com ([37.187.137.238]:59978 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751865AbcD2IbF (ORCPT ); Fri, 29 Apr 2016 04:31:05 -0400 Date: Fri, 29 Apr 2016 10:31:02 +0200 From: Boris Brezillon To: Han Xu Cc: , , , , Subject: Re: [PATCH] mtd: nand: gpmi: get correct free oob space Message-ID: <20160429103102.10ca50f7@bbrezillon> In-Reply-To: <20160413004351.40064fcd@bbrezillon> References: <1460498793-19431-1-git-send-email-han.xu@nxp.com> <20160413004351.40064fcd@bbrezillon> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 732 Lines: 29 Hi Han, On Wed, 13 Apr 2016 00:43:51 +0200 Boris Brezillon wrote: > Hi Han, > > On Tue, 12 Apr 2016 17:06:33 -0500 > Han Xu wrote: > > > change the way to calculate pagesize to get correct free oob space for > > legacy_set_geometry function. > > Are you sure it's safe to expose free OOB bytes in this case? Do you > know why it wasn't done before? You did not answer this question. Do you want me to drop this patch. If that's not the case, can you confirm it does not break platforms that didn't have those free OOB bytes exposed before this change. Thanks, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com