Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752818AbcD2Ijl (ORCPT ); Fri, 29 Apr 2016 04:39:41 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:38035 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751657AbcD2Iji (ORCPT ); Fri, 29 Apr 2016 04:39:38 -0400 Date: Fri, 29 Apr 2016 09:39:35 +0100 From: Matt Fleming To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, ard.biesheuvel@linaro.org, bp@alien8.de, tglx@linutronix.de, tony.luck@intel.com, hpa@zytor.com, linux-tip-commits@vger.kernel.org Subject: Re: [PATCH] efi: Remove unnecessary (and buggy) .memmap initialization from the Xen EFI driver Message-ID: <20160429083935.GA2839@codeblueprint.co.uk> References: <1461614832-17633-8-git-send-email-matt@codeblueprint.co.uk> <20160429083128.GA4925@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160429083128.GA4925@gmail.com> User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 831 Lines: 28 On Fri, 29 Apr, at 10:31:28AM, Ingo Molnar wrote: > > So this commit triggered the follwing build warning on x86 64-bit allyesconfig: Doh! I wonder why the 0day bot didn't tell me about this? > It's this initialization in drivers/xen/efi.c: > > static const struct efi efi_xen __initconst = { > ... > .memmap = NULL, /* Not used under Xen. */ > ... > > which was forgotten about, as .memmap now is an embedded struct: > > struct efi_memory_map memmap; > > We can remove this initialization - it's an EFI core internal data structure plus > it's not used in the Xen driver anyway. > > Signed-off-by: Ingo Molnar > --- > drivers/xen/efi.c | 1 - > 1 file changed, 1 deletion(-) Yep, looks good. Thanks Ingo! Reviewed-by: Matt Fleming