Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751693AbcD2ItP (ORCPT ); Fri, 29 Apr 2016 04:49:15 -0400 Received: from out4133-34.mail.aliyun.com ([42.120.133.34]:60445 "EHLO out4133-34.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751122AbcD2ItN (ORCPT ); Fri, 29 Apr 2016 04:49:13 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R901e4;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e02c03275;MF=hillf.zj@alibaba-inc.com;NM=1;PH=DS;RN=2;SR=0;TI=SMTPD_----4kfRNiQ_1461919731; Reply-To: "Hillf Danton" From: "Hillf Danton" To: "Gustavo Padovan" Cc: "linux-kernel" References: <00fc01d1a1f3$bed68630$3c839290$@alibaba-inc.com> In-Reply-To: <00fc01d1a1f3$bed68630$3c839290$@alibaba-inc.com> Subject: Re: [PATCH v2 05/13] staging/android: make sync_file_fdget() static Date: Fri, 29 Apr 2016 16:48:51 +0800 Message-ID: <00fd01d1a1f3$f48fe190$ddafa4b0$@alibaba-inc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQGRaZU6pU/NTe8MiNGHl985WkFoKaAhFGGA Content-Language: zh-cn Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1744 Lines: 54 > > From: Gustavo Padovan > > There is no plan in the near future to use this function outside of this > file so keep it as static. > > Signed-off-by: Gustavo Padovan > Reviewed-by: Daniel Vetter > --- Acked-by: Hillf Danton > drivers/staging/android/sync.c | 3 +-- > drivers/staging/android/sync.h | 1 - > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c > index e9bf251..7e0fa20 100644 > --- a/drivers/staging/android/sync.c > +++ b/drivers/staging/android/sync.c > @@ -212,7 +212,7 @@ EXPORT_SYMBOL(sync_file_create); > * Ensures @fd references a valid sync_file, increments the refcount of the > * backing file. Returns the sync_file or NULL in case of error. > */ > -struct sync_file *sync_file_fdget(int fd) > +static struct sync_file *sync_file_fdget(int fd) > { > struct file *file = fget(fd); > > @@ -228,7 +228,6 @@ err: > fput(file); > return NULL; > } > -EXPORT_SYMBOL(sync_file_fdget); > > static void sync_file_add_pt(struct sync_file *sync_file, int *i, > struct fence *fence) > diff --git a/drivers/staging/android/sync.h b/drivers/staging/android/sync.h > index ffc6df6..1f164df 100644 > --- a/drivers/staging/android/sync.h > +++ b/drivers/staging/android/sync.h > @@ -168,7 +168,6 @@ void sync_timeline_signal(struct sync_timeline *obj); > struct fence *sync_pt_create(struct sync_timeline *parent, int size); > > struct sync_file *sync_file_create(const char *name, struct fence *fence); > -struct sync_file *sync_file_fdget(int fd); > > #ifdef CONFIG_DEBUG_FS > > -- > 2.5.5 > >