Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752881AbcD2JBu (ORCPT ); Fri, 29 Apr 2016 05:01:50 -0400 Received: from mail-oi0-f46.google.com ([209.85.218.46]:36340 "EHLO mail-oi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752625AbcD2JBq (ORCPT ); Fri, 29 Apr 2016 05:01:46 -0400 MIME-Version: 1.0 In-Reply-To: <1461580714-22479-4-git-send-email-ldewangan@nvidia.com> References: <1461580714-22479-1-git-send-email-ldewangan@nvidia.com> <1461580714-22479-4-git-send-email-ldewangan@nvidia.com> Date: Fri, 29 Apr 2016 11:01:44 +0200 Message-ID: Subject: Re: [PATCH V5 3/4] gpio: tegra: Get rid of all file scoped global variables From: Linus Walleij To: Laxman Dewangan Cc: Stephen Warren , Alexandre Courbot , Thierry Reding , "linux-gpio@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 454 Lines: 14 On Mon, Apr 25, 2016 at 12:38 PM, Laxman Dewangan wrote: > Move the file scoped multiple global variable from Tegra GPIO > driver to the structure and make this as gpiochip data which > can be referred from GPIO chip callbacks. > > Signed-off-by: Laxman Dewangan > Reviewed-by: Stephen Warren > Reviewed-by: Alexandre Courbot Patch applied. Yours, Linus Walleij