Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753031AbcD2JHr (ORCPT ); Fri, 29 Apr 2016 05:07:47 -0400 Received: from mail-oi0-f53.google.com ([209.85.218.53]:33272 "EHLO mail-oi0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752427AbcD2JHn (ORCPT ); Fri, 29 Apr 2016 05:07:43 -0400 MIME-Version: 1.0 In-Reply-To: <1461580714-22479-1-git-send-email-ldewangan@nvidia.com> References: <1461580714-22479-1-git-send-email-ldewangan@nvidia.com> Date: Fri, 29 Apr 2016 11:07:42 +0200 Message-ID: Subject: Re: [PATCH V5 0/4] gpio: tegra: Cleanups and support for debounce From: Linus Walleij To: Laxman Dewangan Cc: Stephen Warren , Alexandre Courbot , Thierry Reding , "linux-gpio@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 637 Lines: 20 On Mon, Apr 25, 2016 at 12:38 PM, Laxman Dewangan wrote: > Add support for the debounce as Tegra210 support debounce in HW. > Also do the clenaups to remove all global variables. OK this v5 is applied. Laxman does this GPIO also have open drain and/or open source handling? Then you might want to look into supporting that too as I just added support for native single-endedness to gpiolib, c.f.: http://marc.info/?l=linux-gpio&m=146011780301280&w=2 It would be nice if you also implement .get_direction() which makes debugfs and initial reading of the state of the lines more accurate. Yours, Linus Walleij