Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752791AbcD2Jgu (ORCPT ); Fri, 29 Apr 2016 05:36:50 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:51855 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752490AbcD2Jgs (ORCPT ); Fri, 29 Apr 2016 05:36:48 -0400 Subject: Re: [PATCH RFT v2 2/2] macb: kill PHY reset code To: Sergei Shtylyov , References: <19240252.825Vlx6L0H@wasted.cogentembedded.com> <2024144.Eda96jDyaz@wasted.cogentembedded.com> CC: From: Nicolas Ferre Organization: atmel Message-ID: <57232B34.4060107@atmel.com> Date: Fri, 29 Apr 2016 11:36:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <2024144.Eda96jDyaz@wasted.cogentembedded.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2594 Lines: 77 Le 29/04/2016 00:15, Sergei Shtylyov a ?crit : > With the 'phylib' now being aware of the "reset-gpios" PHY node property, > there should be no need to frob the PHY reset in this driver anymore... > > Signed-off-by: Sergei Shtylyov Acked-by: Nicolas Ferre So I queue my DT patch through arm-soc. Thanks Sergei, bye. > --- > drivers/net/ethernet/cadence/macb.c | 17 ----------------- > drivers/net/ethernet/cadence/macb.h | 1 - > 2 files changed, 18 deletions(-) > > Index: net-next/drivers/net/ethernet/cadence/macb.c > =================================================================== > --- net-next.orig/drivers/net/ethernet/cadence/macb.c > +++ net-next/drivers/net/ethernet/cadence/macb.c > @@ -2884,7 +2884,6 @@ static int macb_probe(struct platform_de > = macb_clk_init; > int (*init)(struct platform_device *) = macb_init; > struct device_node *np = pdev->dev.of_node; > - struct device_node *phy_node; > const struct macb_config *macb_config = NULL; > struct clk *pclk, *hclk = NULL, *tx_clk = NULL; > unsigned int queue_mask, num_queues; > @@ -2977,18 +2976,6 @@ static int macb_probe(struct platform_de > else > macb_get_hwaddr(bp); > > - /* Power up the PHY if there is a GPIO reset */ > - phy_node = of_get_next_available_child(np, NULL); > - if (phy_node) { > - int gpio = of_get_named_gpio(phy_node, "reset-gpios", 0); > - > - if (gpio_is_valid(gpio)) { > - bp->reset_gpio = gpio_to_desc(gpio); > - gpiod_direction_output(bp->reset_gpio, 1); > - } > - } > - of_node_put(phy_node); > - > err = of_get_phy_mode(np); > if (err < 0) { > pdata = dev_get_platdata(&pdev->dev); > @@ -3054,10 +3041,6 @@ static int macb_remove(struct platform_d > mdiobus_unregister(bp->mii_bus); > mdiobus_free(bp->mii_bus); > > - /* Shutdown the PHY if there is a GPIO reset */ > - if (bp->reset_gpio) > - gpiod_set_value(bp->reset_gpio, 0); > - > unregister_netdev(dev); > clk_disable_unprepare(bp->tx_clk); > clk_disable_unprepare(bp->hclk); > Index: net-next/drivers/net/ethernet/cadence/macb.h > =================================================================== > --- net-next.orig/drivers/net/ethernet/cadence/macb.h > +++ net-next/drivers/net/ethernet/cadence/macb.h > @@ -832,7 +832,6 @@ struct macb { > unsigned int dma_burst_length; > > phy_interface_t phy_interface; > - struct gpio_desc *reset_gpio; > > /* AT91RM9200 transmit */ > struct sk_buff *skb; /* holds skb until xmit interrupt completes */ > > -- Nicolas Ferre