Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753228AbcD2Jyl (ORCPT ); Fri, 29 Apr 2016 05:54:41 -0400 Received: from terminus.zytor.com ([198.137.202.10]:53238 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753137AbcD2JyH (ORCPT ); Fri, 29 Apr 2016 05:54:07 -0400 Date: Fri, 29 Apr 2016 02:53:37 -0700 From: tip-bot for Ingo Molnar Message-ID: Cc: peterz@infradead.org, hpa@zytor.com, linux-kernel@vger.kernel.org, matt@codeblueprint.co.uk, mingo@kernel.org, tglx@linutronix.de Reply-To: peterz@infradead.org, hpa@zytor.com, matt@codeblueprint.co.uk, linux-kernel@vger.kernel.org, mingo@kernel.org, tglx@linutronix.de In-Reply-To: <20160429083128.GA4925@gmail.com> References: <20160429083128.GA4925@gmail.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:efi/core] efi: Remove unnecessary (and buggy) .memmap initialization from the Xen EFI driver Git-Commit-ID: 0ec7ae928a9c19c2b7b8054507d5694a2597065e X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1972 Lines: 56 Commit-ID: 0ec7ae928a9c19c2b7b8054507d5694a2597065e Gitweb: http://git.kernel.org/tip/0ec7ae928a9c19c2b7b8054507d5694a2597065e Author: Ingo Molnar AuthorDate: Fri, 29 Apr 2016 10:31:28 +0200 Committer: Ingo Molnar CommitDate: Fri, 29 Apr 2016 11:06:15 +0200 efi: Remove unnecessary (and buggy) .memmap initialization from the Xen EFI driver So the following commit: 884f4f66ffd6 ("efi: Remove global 'memmap' EFI memory map") ... triggered the following build warning on x86 64-bit allyesconfig: drivers/xen/efi.c:290:47: warning: missing braces around initializer [-Wmissing-braces] It's this initialization in drivers/xen/efi.c: static const struct efi efi_xen __initconst = { ... .memmap = NULL, /* Not used under Xen. */ ... which was forgotten about, as .memmap now is an embedded struct: struct efi_memory_map memmap; We can remove this initialization - it's an EFI core internal data structure plus it's not used in the Xen driver anyway. Reviewed-by: Matt Fleming Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: ard.biesheuvel@linaro.org Cc: bp@alien8.de Cc: linux-tip-commits@vger.kernel.org Cc: tony.luck@intel.com Link: http://lkml.kernel.org/r/20160429083128.GA4925@gmail.com Signed-off-by: Ingo Molnar --- drivers/xen/efi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/xen/efi.c b/drivers/xen/efi.c index be7e56a..e9d2135 100644 --- a/drivers/xen/efi.c +++ b/drivers/xen/efi.c @@ -316,7 +316,6 @@ static const struct efi efi_xen __initconst = { .get_next_high_mono_count = xen_efi_get_next_high_mono_count, .reset_system = NULL, /* Functionality provided by Xen. */ .set_virtual_address_map = NULL, /* Not used under Xen. */ - .memmap = NULL, /* Not used under Xen. */ .flags = 0 /* Initialized later. */ };