Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752570AbcD2KZ1 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 29 Apr 2016 06:25:27 -0400
Received: from mail-wm0-f45.google.com ([74.125.82.45]:35057 "EHLO
	mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751068AbcD2KZZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 29 Apr 2016 06:25:25 -0400
MIME-Version: 1.0
In-Reply-To: <CA+rthh98mYF8heKzEN6Y28ATgjXL54_i6DTKpRV4B52r3hmofA@mail.gmail.com>
References: <1461870258-17970-1-git-send-email-minipli@googlemail.com>
	<20160428143058.0c12162dbc11461144cfa57f@linux-foundation.org>
	<CA+rthh98mYF8heKzEN6Y28ATgjXL54_i6DTKpRV4B52r3hmofA@mail.gmail.com>
Date: Fri, 29 Apr 2016 13:25:24 +0300
Message-ID: <CACVxJT_mZhX7G7q31WW+EY_sT-KJXFDnQ29j0D1YF6Nba_Ld3g@mail.gmail.com>
Subject: Re: [PATCH] proc: prevent accessing /proc/<PID>/environ until it's ready
From: Alexey Dobriyan <adobriyan@gmail.com>
To: Mathias Krause <minipli@googlemail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Emese Revfy <re.emese@gmail.com>, Pax Team <pageexec@freemail.hu>,
        Al Viro <viro@zeniv.linux.org.uk>, Mateusz Guzik <mguzik@redhat.com>,
        Cyrill Gorcunov <gorcunov@openvz.org>, Jarod Wilson <jarod@redhat.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1550
Lines: 31

On Fri, Apr 29, 2016 at 9:02 AM, Mathias Krause <minipli@googlemail.com> wrote:
> On 28 April 2016 at 23:30, Andrew Morton <akpm@linux-foundation.org> wrote:
>> On Thu, 28 Apr 2016 21:04:18 +0200 Mathias Krause <minipli@googlemail.com> wrote:
>>
>>> If /proc/<PID>/environ gets read before the envp[] array is fully set
>>> up in create_{aout,elf,elf_fdpic,flat}_tables(), we might end up trying
>>> to read more bytes than are actually written, as env_start will already
>>> be set but env_end will still be zero, making the range calculation
>>> underflow, allowing to read beyond the end of what has been written.
>>>
>>> Fix this as it is done for /proc/<PID>/cmdline by testing env_end for
>>> zero. It is, apparently, intentionally set last in create_*_tables().
>>
>> Also, if this is indeed our design then
>>
>> a) the various create_*_tables() should have comments in there which
>>    explain this subtlety to the reader.  Or, better, they use a common
>>    helper function for this readiness-signaling operation because..
>>
>> b) we'll need some barriers there to ensure that the environ_read()
>>    caller sees the create_*_tables() writes in the correct order.
>
> I totally agree that this kind of "synchronization" is rather fragile.
> Adding comments won't help much, I fear. Rather a dedicated flag,
> signaling "process ready for inspection" may be needed. So far, that's
> what env_end is (ab-)used for.

If MM Cabal is OK with MMF_LOAD_BINARY_OK flag
applied at search_binary_handler(), it should work for /proc .

    Alexey