Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752957AbcD2KZm (ORCPT ); Fri, 29 Apr 2016 06:25:42 -0400 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:6254 "EHLO mx0a-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752685AbcD2KZe (ORCPT ); Fri, 29 Apr 2016 06:25:34 -0400 From: Amitkumar Karwar To: CC: , Ganapathi Bhat , Amitkumar Karwar Subject: [PATCH v9 2/3] Bluetooth: hci_uart: check if hdev is present before using it Date: Fri, 29 Apr 2016 03:24:37 -0700 Message-ID: <1461925478-31851-2-git-send-email-akarwar@marvell.com> X-Mailer: git-send-email 1.7.3.4 In-Reply-To: <1461925478-31851-1-git-send-email-akarwar@marvell.com> References: <1461925478-31851-1-git-send-email-akarwar@marvell.com> MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-04-29_06:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1603290000 definitions=main-1604290162 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1160 Lines: 37 From: Ganapathi Bhat The hdev struct might not have initialized in protocal receive handler. This patch adds necessary checks. Signed-off-by: Ganapathi Bhat Signed-off-by: Amitkumar Karwar --- drivers/bluetooth/hci_ldisc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_ldisc.c index 075a82d..3ee8c0c 100644 --- a/drivers/bluetooth/hci_ldisc.c +++ b/drivers/bluetooth/hci_ldisc.c @@ -154,7 +154,9 @@ restart: set_bit(TTY_DO_WRITE_WAKEUP, &tty->flags); len = tty->ops->write(tty, skb->data, skb->len); - hdev->stat.byte_tx += len; + + if (hdev) + hdev->stat.byte_tx += len; skb_pull(skb, len); if (skb->len) { @@ -349,7 +351,7 @@ void hci_uart_set_baudrate(struct hci_uart *hu, unsigned int speed) /* tty_set_termios() return not checked as it is always 0 */ tty_set_termios(tty, &ktermios); - BT_DBG("%s: New tty speeds: %d/%d", hu->hdev->name, + BT_DBG("%s: New tty speeds: %d/%d", hu->hdev ? hu->hdev->name : "", tty->termios.c_ispeed, tty->termios.c_ospeed); } -- 1.8.1.4