Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752908AbcD2LAI (ORCPT <rfc822;w@1wt.eu>);
	Fri, 29 Apr 2016 07:00:08 -0400
Received: from mail.eperm.de ([89.247.134.16]:54184 "EHLO mail.eperm.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751834AbcD2LAE convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 29 Apr 2016 07:00:04 -0400
From: Stephan Mueller <sm@eperm.de>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: linux-kernel@vger.kernel.org, corbet@lwn.net, herbert@gondor.apana.org.au,
        davem@davemloft.net, linux-doc@vger.kernel.org,
        linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: Add a flag allowing the self-tests to be disabled at runtime.
Date: Fri, 29 Apr 2016 12:59:57 +0200
Message-ID: <1716181.h8M5zx62aT@tauon.atsec.com>
User-Agent: KMail/4.14.10 (Linux/4.4.7-300.fc23.x86_64; KDE/4.14.18; x86_64; ; )
In-Reply-To: <1461924463-1678-2-git-send-email-rjones@redhat.com>
References: <1461924463-1678-1-git-send-email-rjones@redhat.com> <1461924463-1678-2-git-send-email-rjones@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
Content-Type: text/plain; charset="iso-8859-1"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2035
Lines: 69

Am Freitag, 29. April 2016, 11:07:43 schrieb Richard W.M. Jones:

Hi Richard,

> Running self-tests for a short-lived KVM VM takes 28ms on my laptop.
> This commit adds a flag 'cryptomgr.notests' which allows them to be
> disabled.
> 
> Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
> ---
>  Documentation/kernel-parameters.txt | 3 +++
>  crypto/testmgr.c                    | 9 +++++++++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/Documentation/kernel-parameters.txt
> b/Documentation/kernel-parameters.txt index 0b3de80..d4d5fb7 100644
> --- a/Documentation/kernel-parameters.txt
> +++ b/Documentation/kernel-parameters.txt
> @@ -826,6 +826,9 @@ bytes respectively. Such letter suffixes can also be
> entirely omitted. It will be ignored when crashkernel=X,high is not used
>  			or memory reserved is below 4G.
> 
> +	cryptomgr.notests
> +                        [KNL] Disable crypto self-tests
> +
>  	cs89x0_dma=	[HW,NET]
>  			Format: <dma>
> 
> diff --git a/crypto/testmgr.c b/crypto/testmgr.c
> index b86883a..dc613f2 100644
> --- a/crypto/testmgr.c
> +++ b/crypto/testmgr.c
> @@ -35,6 +35,10 @@
> 
>  #include "internal.h"
> 
> +static bool notests;
> +module_param(notests, bool, 0644);
> +MODULE_PARM_DESC(notests, "disable crypto self-tests");
> +
>  #ifdef CONFIG_CRYPTO_MANAGER_DISABLE_TESTS
> 
>  /* a perfect nop */
> @@ -3868,6 +3872,11 @@ int alg_test(const char *driver, const char *alg, u32
> type, u32 mask) int j;
>  	int rc;
> 
> +	if (notests) {

What about if (!fips_enabled && notests) ?

I am not sure whether the kernel should prevent mistakes in user space. A 
mistake would be when setting fips=1 and notests=1 as the FIPS mode mandates 
the self tests.

> +		pr_info("alg: self-tests disabled\n");
> +		return 0;
> +	}
> +
>  	alg_test_descs_check_order();
> 
>  	if ((type & CRYPTO_ALG_TYPE_MASK) == CRYPTO_ALG_TYPE_CIPHER) {


Ciao
Stephan
-- 
| Nimm das Recht weg -                                             |
|  was ist dann der Staat noch anderes als eine gro?e R?uberbande? |