Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753492AbcD2MNd (ORCPT ); Fri, 29 Apr 2016 08:13:33 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:51680 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753122AbcD2MNb (ORCPT ); Fri, 29 Apr 2016 08:13:31 -0400 Subject: Re: [PATCH] ARM: dts: omap5-igep0050: Correct hdmi regulator To: References: <1461925297-9734-1-git-send-email-peter.ujfalusi@ti.com> CC: , , , From: Peter Ujfalusi Message-ID: <6ee9d67a-e907-715a-f3f5-d90a470314c3@ti.com> Date: Fri, 29 Apr 2016 13:22:32 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <1461925297-9734-1-git-send-email-peter.ujfalusi@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1401 Lines: 52 On 04/29/16 13:21, Peter Ujfalusi wrote: > ldo7_reg should not work as regulator since it is set to 'disabled' state > in the omap5-board-common.dtsi and the state is not changed to 'okay' > this means that the ldo7_reg is not available to be used in the igep0050 > DTS file. > ldo4_reg is used by all other OMAP5 boards and this is most likely the > correct regulator to use with hdmi. > The hdmi needs 1.8V, but the ldo7_reg, based on the dtsi is 2V only. > > Signed-off-by: Peter Ujfalusi > --- > Tony, > > I don't have access to the schematics, but I believe tha the ldo7_reg is not the > correct regulator to be used for hdmi. > > If you have access and it is really ldo7_reg, then we should have this in the > omap5-igep0050.dts file: > > &ldo5_reg { ldo7_reg, obviously ;) > status = "okay"; > regulator-min-microvolt = <1800000>; > regulator-max-microvolt = <1800000>; > }; > > Regards, > Peter > > arch/arm/boot/dts/omap5-igep0050.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/omap5-igep0050.dts b/arch/arm/boot/dts/omap5-igep0050.dts > index 46ecb1dd3b5c..6c8d40327c68 100644 > --- a/arch/arm/boot/dts/omap5-igep0050.dts > +++ b/arch/arm/boot/dts/omap5-igep0050.dts > @@ -20,7 +20,7 @@ > }; > > &hdmi { > - vdda-supply = <&ldo7_reg>; > + vdda-supply = <&ldo4_reg>; > }; > > &i2c4 { > -- P?ter