Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753566AbcD2MQk (ORCPT ); Fri, 29 Apr 2016 08:16:40 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:37579 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753193AbcD2MQi (ORCPT ); Fri, 29 Apr 2016 08:16:38 -0400 Date: Fri, 29 Apr 2016 13:16:35 +0100 From: Matt Fleming To: "Compostella, Jeremy" Cc: Ingo Molnar , stefan.stanacar@intel.com, peterz@infradead.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, hpa@zytor.com, bp@alien8.de, ard.biesheuvel@linaro.org, linux-tip-commits@vger.kernel.org Subject: Re: [tip:efi/core] efibc: Add EFI Bootloader Control module Message-ID: <20160429121635.GF2839@codeblueprint.co.uk> References: <1461614832-17633-26-git-send-email-matt@codeblueprint.co.uk> <20160429095356.GA29957@gmail.com> <20160429103011.GE2839@codeblueprint.co.uk> <87lh3wejfi.fsf@jcompost-MOBL1.tl.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87lh3wejfi.fsf@jcompost-MOBL1.tl.intel.com> User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 647 Lines: 14 On Fri, 29 Apr, at 01:36:01PM, Jeremy Compostella wrote: > I would go for this last proposal because it fixes the issue, it works > with the potential race condition you mentioned and it is a simple > solution. Yet, it means that if we really run into a race condition, > the LoaderEntryOneShot value might be indeterminate. > > Though, this is a very unlikely situation and if it happens I cannot > think of any good reason to prefer to store the first restart target > or the second. > > Do you want me to make this change ? Yes please, that'd be greatly appreciated. Be sure to do it on top of either the EFI 'next' branch or tip:efi/core.