Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753613AbcD2MSL (ORCPT ); Fri, 29 Apr 2016 08:18:11 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:52359 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753364AbcD2MSJ (ORCPT ); Fri, 29 Apr 2016 08:18:09 -0400 Subject: Re: [PATCH] Revert "drm/omap: no need to select OMAP2_DSS" To: Peter Ujfalusi , , References: <1461847369-32637-1-git-send-email-peter.ujfalusi@ti.com> CC: , , From: Tomi Valkeinen Message-ID: <57233CED.5070002@ti.com> Date: Fri, 29 Apr 2016 13:52:29 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1461847369-32637-1-git-send-email-peter.ujfalusi@ti.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xLxrljGj5XM38WVkLbcArV3f0qJVNTSJO" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2750 Lines: 77 --xLxrljGj5XM38WVkLbcArV3f0qJVNTSJO Content-Type: multipart/mixed; boundary="oASaj7pSXmnjU5qNxdtDqJblC4Nqlawux" From: Tomi Valkeinen To: Peter Ujfalusi , airlied@linux.ie, laurent.pinchart@ideasonboard.com Cc: robdclark@gmail.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Message-ID: <57233CED.5070002@ti.com> Subject: Re: [PATCH] Revert "drm/omap: no need to select OMAP2_DSS" References: <1461847369-32637-1-git-send-email-peter.ujfalusi@ti.com> In-Reply-To: <1461847369-32637-1-git-send-email-peter.ujfalusi@ti.com> --oASaj7pSXmnjU5qNxdtDqJblC4Nqlawux Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 28/04/16 15:42, Peter Ujfalusi wrote: > This reverts commit 1c278e5e3718d15475ec08ee2135f37a6b13361c. >=20 > If DRM_OMAP does not select OMAP2_DSS it is possible to build a kernel = with > DRM_OMAP only and not selecting OMAP2_DSS. Since omapdrm depends on > OMAP2_DSS this will result on broken kernel build. >=20 > Signed-off-by: Peter Ujfalusi > --- > drivers/gpu/drm/omapdrm/Kconfig | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/gpu/drm/omapdrm/Kconfig b/drivers/gpu/drm/omapdrm/= Kconfig > index 73241c4eb7aa..336ad4de9981 100644 > --- a/drivers/gpu/drm/omapdrm/Kconfig > +++ b/drivers/gpu/drm/omapdrm/Kconfig > @@ -2,6 +2,7 @@ config DRM_OMAP > tristate "OMAP DRM" > depends on DRM > depends on ARCH_OMAP2PLUS || ARCH_MULTIPLATFORM > + select OMAP2_DSS > select DRM_KMS_HELPER > select DRM_KMS_FB_HELPER > select FB_SYS_FILLRECT >=20 Thanks, queued for 4.7. Tomi --oASaj7pSXmnjU5qNxdtDqJblC4Nqlawux-- --xLxrljGj5XM38WVkLbcArV3f0qJVNTSJO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXIzztAAoJEPo9qoy8lh71HhMQALAI9OenAxnwtsW2fW+epMBK auldM5hjV36wXoNV6TxtoKC7KLLXiAyxE/EOBnKY+YYNHoqD5ujv3KdSjSIPTc16 WCALfyYHdGZ+Qr6+IglWNxaqR5VA+r75zPE9bWHYnWS9U6s7DD/+NGKaR/PwhoJp YRDIHtpJ2XBI9RiOyG/Za0JtLrN84q9ZmHpyvSxfl3Y5cXxC47s4ELntdib+ZL6/ Nsnb2o6LAi3GFDc1kv1jIWc5D4SU5t9ov3iG0dPdv5Moyg/qIA6fdJeSjtfC/9K+ xATYP1ZKc0kXcjvzZUd9pjtCheUYMq/vzRO6zMd5sYk6RpGS4VM8U6zSnnjsuXls 5vp+VvzYyPijiWMTFuRSe0AlVvfoqM4OM1Z9H/4qYPfnjTH9yoWfUCXTNJBRqz/S sfu7ds78b1oY9Upcce7WGPmKRoL8o3gLwRB8HRvvC4TdudGCaN0IYV9jF1pCDGEn f0bd+Fc99ZKYjSIDrMJyPAkbAqmwkQz4NuwzPrUPiolevywl+jSsw6AmYtCkIWWO tU6+1DBmPhon/tzwukUWGTTJVwHo48vXT6sJc8FUz/Mr9KdNWNZ3RU/pCqDT5QHs 4sCddj0xTCelCBCEw7Nx2IfMVYR5AhhVq/k8iHDRyiaHFYddUD+Zm32VD514wYy/ FPKZJ3b9UD45pWVBDCkp =HruT -----END PGP SIGNATURE----- --xLxrljGj5XM38WVkLbcArV3f0qJVNTSJO--